Chore: implement test on article tags #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add validation to tag function - add test [Finishes]
houndci-bot
reviewed
Apr 5, 2019
tests/tag.test.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| import chai from 'chai'; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
rotimi-babalola
suggested changes
Apr 5, 2019
| tagging.saveArticleTags(1); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
What exactly are you testing in this test suite? @AnayoOleru I can't see any assertions in any of your tests
- add assertions [Finishes]
houndci-bot
reviewed
Apr 8, 2019
| chai.use(chaiHttp); | ||
|
|
||
| describe('Tags', () => { | ||
| it('should accept an id and string of article tags', async () => { |
- remove commented code [Finishes]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement test on article tags function, to make sure they are handling the errors and returning the right values properly.
Type of change
How Has This Been Tested?
Checklist:
PT-ID
N/A
Screenshots
Background
N/A
Questions
N/A