-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft create article model manager #163359470 #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 23, 2019
ibraheemkabir
force-pushed
the
ft-create-article-model-manager-#163359470
branch
4 times, most recently
from
January 23, 2019 14:31
c7e2a45
to
0898fc2
Compare
houndci-bot
reviewed
Jan 23, 2019
ibraheemkabir
force-pushed
the
ft-create-article-model-manager-#163359470
branch
4 times, most recently
from
January 23, 2019 15:35
5b37b26
to
fa19702
Compare
codrex
reviewed
Jan 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
ibraheemkabir
force-pushed
the
ft-create-article-model-manager-#163359470
branch
4 times, most recently
from
January 23, 2019 18:37
2cbc671
to
f814271
Compare
eltNEG
reviewed
Jan 23, 2019
ibraheemkabir
force-pushed
the
ft-create-article-model-manager-#163359470
branch
from
January 23, 2019 20:42
f814271
to
978c4b3
Compare
eltNEG
approved these changes
Jan 24, 2019
codrex
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets up article model manager for article queries.
This PR also includes relations to other necessary tables.
Description of Task to be completed?
Sets up the user model manager.
How should this be manually tested?
This can be manually tested by pulling the branch and running db:migrate
git pull the current repository
Switch to Ft-create-article-model-manager-#163359470 branch
Run npm install to install all dependencies.
To test the models using mocha
Run
npm test
What are the relevant pivotal tracker stories?
#163187121