New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161290903 CRUD operations for articles #13

Merged

desaawa merged 1 commit into develop from feature/161290903/CRUD-operations-for-articles

Nov 5, 2018

Contributor

hope-uwa commented Nov 1, 2018 •

edited

Loading

What does this PR do?

Allows any user to view all articles and specific articles
Allows authenticated users to view, create, edit and delete articles

Description of Task to be completed?

created migration and model for articles with associations
wrote validations for request.body of articles.
wrote test with 100% coverage of article controller branches
installed slug dependency package and created a set function to merge user uuid and title slug
GET api/v1/articles unprotected - it fetches all published articles
GET api/v1/articles/drafts protected - it fetches all drafts by the authenticated user
GET api/v1/users/articles protected - it fetches all published article by the authenticated user
GET api/v1/articles/:slug unprotected - it fetches an article with slug parameter
POST api/v1/articles protected - it creates an article
PUT api/v1/articles/:slug/publish protected - it allows only author to publish article.
PUT api/v1/articles/:slug protected - it allows authors to edit their articles whether published or draft
DELETE api/v1/articles/:slug protected - it allows authors to delete their own articles.

How should this be manually tested?

clone this repository
run npm install on command line
create postgres database
create .env file
set up environment variables using the sample on .envsample file
Run npm run dev on command/shell
Using postman test the endpoint with prefix- localhost:3000

Any background context you want to provide?

Some of the endpoints are protected so you will need to sign up with users/register

What are the relevant pivotal tracker stories?

#161290903

Screenshots (if appropriate)

Questions:

houndci-bot reviewed

View reviewed changes

server/src/db/seeders/20181029220340-demo-articles.js Outdated

+                  queryInterface.bulkInsert('Article', mockArticle, {});
+                },
+                down: (queryInterface, Sequelize) => {

houndci-bot Nov 1, 2018

'Sequelize' is defined but never used no-unused-vars

server/src/db/seeders/20181029220340-demo-articles.js Outdated

+              import mockArticle from '../../helpers/seedData/articles.json';
+              export default {
+                up: (queryInterface, Sequelize) => {

houndci-bot Nov 1, 2018

'Sequelize' is defined but never used no-unused-vars

server/src/db/seeders/20181029220222-demo-user.js Outdated


		},

		down: (queryInterface, Sequelize) => {

houndci-bot Nov 1, 2018

'Sequelize' is defined but never used no-unused-vars

server/src/db/seeders/20181029220222-demo-user.js Outdated

+              export default {
+                up: (queryInterface, Sequelize) => { queryInterface.bulkInsert('User', [], {});
+                },

houndci-bot Nov 1, 2018

Block must not be padded by blank lines padded-blocks

server/src/db/seeders/20181029220222-demo-user.js Outdated


		export default {
		up: (queryInterface, Sequelize) => { queryInterface.bulkInsert('User', [], {});

houndci-bot Nov 1, 2018

Trailing spaces not allowed no-trailing-spaces

server/src/db/seeders/20181029220222-demo-user.js Outdated

+              import mockUser from '../../helpers/seedData/users.json';
+              export default {
+                up: (queryInterface, Sequelize) => { queryInterface.bulkInsert('User', [], {});

houndci-bot Nov 1, 2018

'Sequelize' is defined but never used no-unused-vars
Statement inside of curly braces should be on next line brace-style

server/src/db/seeders/20181029220222-demo-user.js Outdated

		@@ -0,0 +1,17 @@
		import mockUser from '../../helpers/seedData/users.json';

houndci-bot Nov 1, 2018

'mockUser' is defined but never used no-unused-vars

server/src/controllers/ArticleController.js Outdated

+                            [Op.like]: `%${articleId}`
+                          }
+                        }
+                      })

houndci-bot Nov 1, 2018

Expected a newline before ')' function-paren-newline

server/src/controllers/ArticleController.js Outdated

+                          message: 'Unauthorized'
+                        });
+                      }
+                      Article.update({

houndci-bot Nov 1, 2018

Expected a newline after '(' function-paren-newline

coveralls commented Nov 1, 2018 •

edited

Loading

Pull Request Test Coverage Report for Build 152

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.472%

Totals
Change from base Build 150:	0.0%
Covered Lines:	752
Relevant Lines:	823

💛 - Coveralls

hope-uwa force-pushed the feature/161290903/CRUD-operations-for-articles branch from 0fa7e2f to 709f33a Compare

November 1, 2018 12:52

houndci-bot reviewed

View reviewed changes

server/src/controllers/ArticleController.js Outdated

+                            [Op.like]: `%${articleId}`
+                          }
+                        }
+                      }).then(() => {

houndci-bot Nov 1, 2018

Expected a newline before ')' function-paren-newline

hope-uwa force-pushed the feature/161290903/CRUD-operations-for-articles branch 4 times, most recently from abac953 to 3b0ded7 Compare

November 1, 2018 16:04

hope-uwa assigned oluseyianani, desaawa, Frediflexta, ajimae, ovieokeh and hope-uwa

hope-uwa changed the title ~~Feature/161290903/crud operations for articles~~ #161290903 CRUD operations for articles

hope-uwa force-pushed the feature/161290903/CRUD-operations-for-articles branch from 3b0ded7 to b3f7918 Compare

November 2, 2018 09:41

ovieokeh mentioned this pull request

#161290913 Add Search Functionality #15

Merged

desaawa approved these changes

View reviewed changes

Contributor

desaawa commented Nov 5, 2018

@uwaelpis Please resolve the conflicts here.

hope-uwa force-pushed the feature/161290903/CRUD-operations-for-articles branch 2 times, most recently from e18986b to 7a6bce5 Compare

November 5, 2018 14:16


          feat(articles): create, read, update and delete articles

4ea7723

            - Write test for endpoints
            - Implemented relationship in model and migration
            - Validationhelpers for articles inputs
            - Create article functionalities
            - Update article functionalities
            - Read article functionalities
            - Delete article functionality

            [Finishes #161290903]

hope-uwa force-pushed the feature/161290903/CRUD-operations-for-articles branch from 7a6bce5 to 4ea7723 Compare

November 5, 2018 14:41

desaawa merged commit 80e605a into develop

This was referenced Nov 7, 2018

#161290909 Add Tagging Functionality #17

Merged

#161872773 Descriptive Response When Searching #25

Merged

hope-uwa mentioned this pull request

#161290917- Report an article #29

Merged

ovieokeh mentioned this pull request

#161987549 Add Categorisation Functionality #31

Merged

oluseyianani mentioned this pull request

#161290916 User Bookmarks Article Of Their Choice #32

Merged

ovieokeh mentioned this pull request

#161290921 Highlight and Comment on an Article #36

Merged

hope-uwa mentioned this pull request

#161290914 article read time #37

Merged

Frediflexta mentioned this pull request

#161290918 Enable Users Like Comments and Replies #38

Merged

This was referenced Nov 22, 2018

#161290920 Role Based Functionality #39

Merged

#161290908 Users Receive In-app and Email Notification #45

Merged

hope-uwa mentioned this pull request

162465047 Format article response #54

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet