#166816103 Enable social login #21

halimahO · 2019-07-08T14:58:38Z

What does this PR do?

Enable facebook login/signup

Description of Task to be completed?

Create facebook/google/twitter apps and generate Ids and secret keys

Setup middleware(passport)that interfaces with the social sites

Create controller function that returns user token after successful login/signup

Write unit tests

How should this be manually tested?

clone the repo using git clone https://github.com/andela/persephone-ah-backend.git
on your terminal, run cd persephone-ah-backend
run npm install to install all dependencies
create a .env file and fill it with the content of the .env.sample

For facebook: request to be a tester

run npm run start

on your browser, go to http://localhost:3000/api/v1/auth/facebook

For twitter

run npm run start

on your browser, go to http://localhost:3000/api/v1/auth/twitter

For google

run npm run start

on your browser, go to http://localhost:3000/api/v1/auth/google

Any background context you want to provide?

For Facebook login: The feature can only be tested by registered testers while still in the development mode. This configuration is set by facebook for security reasons. But when it goes into production, any facebook user can test out the feature.

What are the relevant pivotal tracker stories?

#166816103

Questions:

None

hound · 2019-07-08T14:58:47Z

src/tests/controller/auth.spec.js

+    it('Should return an error 400 when getting all users', () => {
+      const request = {};
+      const response = new Response();
+      sinon.stub(response, 'status').returnsThis();


Replace 'status' with "status" prettier/prettier

hound · 2019-07-08T14:58:47Z

src/tests/controller/auth.spec.js

@@ -192,6 +258,14 @@ describe('Auth API endpoints', () => {
      expect(response).to.have.status(400);
      expect(response.body.status).to.equal('fail');
    });
+
+    it('Should return an error 400 when getting all users', () => {


Replace 'Should·return·an·error·400·when·getting·all·users' with "Should·return·an·error·400·when·getting·all·users" prettier/prettier

hound · 2019-07-08T14:58:47Z

src/tests/controller/auth.spec.js

+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');
+          expect(response.body.data[0].msg).to.equal(
+            'Password can not be less than 8 characters'


Replace 'Password·can·not·be·less·than·8·characters' with "Password·can·not·be·less·than·8·characters" prettier/prettier

hound · 2019-07-08T14:58:47Z

src/tests/controller/auth.spec.js

+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');


Replace 'fail' with "fail" prettier/prettier

hound · 2019-07-08T14:58:47Z

src/tests/controller/auth.spec.js

+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');


Replace 'data' with "data" prettier/prettier

hound · 2019-07-08T14:58:48Z

src/tests/controller/auth.spec.js

+        });
+    });
+
+    it('Should not allow invalid password user input', done => {


Replace 'Should·not·allow·invalid·password·user·input' with "Should·not·allow·invalid·password·user·input" prettier/prettier

hound · 2019-07-08T14:58:48Z

src/tests/controller/auth.spec.js

+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');
+          expect(response.body.data[0].msg).to.equal(
+            'Last name must be only alphabetical chars'


Replace 'Last·name·must·be·only·alphabetical·chars' with "Last·name·must·be·only·alphabetical·chars" prettier/prettier

hound · 2019-07-08T14:58:48Z

src/tests/controller/auth.spec.js

+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');


Replace 'fail' with "fail" prettier/prettier

hound · 2019-07-08T14:58:49Z

src/tests/controller/auth.spec.js

+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');


Replace 'data' with "data" prettier/prettier

hound · 2019-07-08T14:58:49Z

src/tests/controller/auth.spec.js

+        })
+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');


Replace 'status' with "status" prettier/prettier

hound · 2019-07-08T15:23:31Z

src/tests/middleware/auth.spec.js

@@ -3,7 +3,7 @@ import chaiHttp from 'chai-http';
 import dotenv from 'dotenv';
 import sinon from 'sinon';
 import sinonChai from 'sinon-chai';
-import getToken from '../../helpers/jwt.helper';
+import { getToken } from '../../helpers/jwt.helper';


Replace '../../helpers/jwt.helper' with "../../helpers/jwt.helper" prettier/prettier

hound · 2019-07-08T15:23:31Z

src/tests/index.spec.js

@@ -6,3 +6,4 @@ import './middleware/auth.spec';
 import './models/user.spec';
 import './controller/auth.spec';
 import './controller/user.spec';
+import './controller/social.spec';


Replace './controller/social.spec' with "./controller/social.spec" prettier/prettier

hound · 2019-07-08T15:23:32Z

src/tests/controller/social.spec.js

+      const tokenMock = 'fake.token';
+
+      sinon.spy(Helper, 'successResponse');
+      sinon.stub(jwtHelper, 'getToken').returns(tokenMock);


Replace 'getToken' with "getToken" prettier/prettier

hound · 2019-07-08T15:23:32Z

src/tests/controller/social.spec.js

+
+      const tokenMock = 'fake.token';
+
+      sinon.spy(Helper, 'successResponse');


Replace 'successResponse' with "successResponse" prettier/prettier

hound · 2019-07-08T15:23:32Z

src/tests/controller/social.spec.js

+        roleType: 'guest'
+      };
+
+      const tokenMock = 'fake.token';


Replace 'fake.token' with "fake.token" prettier/prettier

hound · 2019-07-08T15:23:33Z

src/tests/controller/social.spec.js

+      json() {}
+    };
+
+    it('responds with 400 for user with no email', async () => {


Replace 'responds·with·400·for·user·with·no·email' with "responds·with·400·for·user·with·no·email" prettier/prettier

hound · 2019-07-08T15:23:33Z

src/tests/controller/social.spec.js

+    });
+  });
+
+  describe('socialRedirect', () => {


Replace 'socialRedirect' with "socialRedirect" prettier/prettier

hound · 2019-07-08T15:23:33Z

src/tests/controller/social.spec.js

+        }
+      };
+
+      sinon.stub(User, 'findOrCreate').returns([userMock]);


Replace 'findOrCreate' with "findOrCreate" prettier/prettier

hound · 2019-07-08T15:23:33Z

src/tests/controller/social.spec.js

+      profileMock.emails = [{ value: 'johndoe@mail.com' }];
+      const userMock = {
+        dataValues: {
+          email: 'johndoe@mail.com'


Replace 'johndoe@mail.com' with "johndoe@mail.com" prettier/prettier

hound · 2019-07-08T15:23:34Z

src/tests/controller/social.spec.js

+
+    it('successfully authenticate and get/create user', async () => {
+      const done = sinon.spy();
+      profileMock.emails = [{ value: 'johndoe@mail.com' }];


Replace 'johndoe@mail.com' with "johndoe@mail.com" prettier/prettier

hound · 2019-07-08T15:23:54Z

src/tests/controller/social.spec.js

+      expect(done).calledOnceWith(null, { noEmail: true });
+    });
+
+    it('successfully authenticate and get/create user', async () => {


Replace 'successfully·authenticate·and·get/create·user' with "successfully·authenticate·and·get/create·user" prettier/prettier

hound · 2019-07-08T15:23:54Z

src/tests/controller/social.spec.js

+      photos: [{ value: 'img.io' }]
+    };
+
+    it('responds with no email', async () => {


Replace 'responds·with·no·email' with "responds·with·no·email" prettier/prettier

hound · 2019-07-08T15:23:54Z

src/tests/controller/social.spec.js

+      id: '122',
+      displayName: 'john doe',
+      provider: 'AH',
+      photos: [{ value: 'img.io' }]


Replace 'img.io' with "img.io" prettier/prettier

hound · 2019-07-08T15:23:55Z

src/tests/controller/social.spec.js

+    const profileMock = {
+      id: '122',
+      displayName: 'john doe',
+      provider: 'AH',


Replace 'AH' with "AH" prettier/prettier

hound · 2019-07-08T15:23:55Z

src/tests/controller/social.spec.js

+  describe('socialCallback', () => {
+    const profileMock = {
+      id: '122',
+      displayName: 'john doe',


Replace 'john·doe' with "john·doe" prettier/prettier

hound · 2019-07-08T15:23:55Z

src/tests/controller/social.spec.js

+import {
+  socialCallback,
+  socialRedirect
+} from '../../controllers/social.controller';


Replace '../../controllers/social.controller' with "../../controllers/social.controller" prettier/prettier

hound · 2019-07-08T15:23:55Z

src/tests/controller/social.spec.js

@@ -0,0 +1,87 @@
+import sinon from 'sinon';
+import sinonChai from 'sinon-chai';
+import chai, { expect } from 'chai';


Replace 'chai' with "chai" prettier/prettier

hound · 2019-07-08T15:23:55Z

src/tests/controller/social.spec.js

@@ -0,0 +1,87 @@
+import sinon from 'sinon';
+import sinonChai from 'sinon-chai';


Replace 'sinon-chai' with "sinon-chai" prettier/prettier

hound · 2019-07-08T15:23:56Z

src/tests/controller/social.spec.js

@@ -0,0 +1,87 @@
+import sinon from 'sinon';


Replace 'sinon' with "sinon" prettier/prettier

hound · 2019-07-08T15:23:56Z

src/services/user.service.js

@@ -1,6 +1,6 @@
 import bcrypt from 'bcryptjs';
 import crypto from 'crypto';
-import getToken from '../helpers/jwt.helper';
+import { getToken } from '../helpers/jwt.helper';


Replace '../helpers/jwt.helper' with "../helpers/jwt.helper" prettier/prettier

hound · 2019-07-09T07:47:50Z

src/services/auth.service.js

@@ -1,6 +1,6 @@
 import bcrypt from 'bcryptjs';
 import crypto from 'crypto';
-import getToken, { getPasswordResetToken } from '../helpers/jwt.helper';
+import { getToken, getPasswordResetToken } from '../helpers/jwt.helper';


Replace '../helpers/jwt.helper' with "../helpers/jwt.helper" prettier/prettier

hound · 2019-07-09T07:47:50Z

src/routes/v1/social.route.js

+
+router
+  .get('/google', passport.authenticate('google', { scope: ['email'] }))
+  .get('/google/callback', passport.authenticate('google'), socialRedirect);


Replace '/google/callback',·passport.authenticate('google' with "/google/callback",·passport.authenticate("google" prettier/prettier

hound · 2019-07-09T07:47:50Z

src/routes/v1/social.route.js

+  );
+
+router
+  .get('/google', passport.authenticate('google', { scope: ['email'] }))


Replace '/google',·passport.authenticate('google',·{·scope:·['email' with "/google",·passport.authenticate("google",·{·scope:·["email" prettier/prettier

hound · 2019-07-09T07:47:50Z

src/routes/v1/social.route.js

+  .get('/twitter', passport.authenticate('twitter', { scope: ['email'] }))
+  .get(
+    '/twitter/callback',
+    passport.authenticate('twitter', { session: false }),


Replace 'twitter' with "twitter" prettier/prettier

hound · 2019-07-09T07:47:50Z

src/routes/v1/social.route.js

+router
+  .get('/twitter', passport.authenticate('twitter', { scope: ['email'] }))
+  .get(
+    '/twitter/callback',


Replace '/twitter/callback' with "/twitter/callback" prettier/prettier

hound · 2019-07-09T07:47:51Z

src/routes/v1/social.route.js

@@ -0,0 +1,27 @@
+import express from 'express';


Replace 'express' with "express" prettier/prettier

hound · 2019-07-09T07:47:51Z

src/routes/v1/index.js


 export default app => {
+  app.use('/api/v1/auth/', socialAuth);


Replace '/api/v1/auth/' with "/api/v1/auth/" prettier/prettier

hound · 2019-07-09T07:47:51Z

src/routes/v1/index.js

@@ -1,7 +1,9 @@
 import auth from './auth.route';
 import users from './user.route';
+import socialAuth from './social.route';


Replace './social.route' with "./social.route" prettier/prettier

hound · 2019-07-09T07:47:52Z

src/index.js

 import swaggerConfig from '../swagger.json';
 import Routes from './routes/v1';
+import './config/passportStrategies';


Replace './config/passportStrategies' with "./config/passportStrategies" prettier/prettier

hound · 2019-07-09T07:47:52Z

src/index.js

@@ -2,16 +2,27 @@ import express from 'express';
 import bodyParser from 'body-parser';
 import swagger from 'swagger-ui-express';
 import logger from 'morgan';
+import passport from 'passport';
+import session from 'express-session';


Replace 'express-session' with "express-session" prettier/prettier

hound · 2019-07-09T11:56:29Z

src/tests/controller/auth.spec.js

+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');
+          expect(response.body.data[0].msg).to.equal(
+            'Last name must be only alphabetical chars'


Replace 'Last·name·must·be·only·alphabetical·chars' with "Last·name·must·be·only·alphabetical·chars" prettier/prettier

hound · 2019-07-09T11:56:29Z

src/tests/controller/auth.spec.js

+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');


Replace 'fail' with "fail" prettier/prettier

hound · 2019-07-09T11:56:29Z

src/tests/controller/auth.spec.js

+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');


Replace 'data' with "data" prettier/prettier

hound · 2019-07-09T11:56:29Z

src/tests/controller/auth.spec.js

+        })
+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');


Replace 'status' with "status" prettier/prettier

hound · 2019-07-09T11:56:29Z

src/tests/controller/auth.spec.js

+        .send({
+          email: 'sandy@gmail.com',
+          password: 'samsss',
+          firstName: 'gfhshs',


Replace 'gfhshs' with "gfhshs" prettier/prettier

hound · 2019-07-09T11:56:30Z

src/tests/controller/auth.spec.js

+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');


Replace 'data' with "data" prettier/prettier

hound · 2019-07-09T11:56:30Z

src/tests/controller/auth.spec.js

+        })
+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');


Replace 'status' with "status" prettier/prettier

hound · 2019-07-09T11:56:30Z

src/tests/controller/auth.spec.js

+          email: 'sandy@gmail.com',
+          password: 'samsss',
+          firstName: 23,
+          lastName: 'ghghghg'


Replace 'ghghghg' with "ghghghg" prettier/prettier

hound · 2019-07-09T11:56:31Z

src/tests/controller/auth.spec.js

+        .post('/api/v1/users/signup')
+        .send({
+          email: 'sandy@gmail.com',
+          password: 'samsss',


Replace 'samsss' with "samsss" prettier/prettier

hound · 2019-07-09T11:56:31Z

src/tests/controller/auth.spec.js

+        .request(app)
+        .post('/api/v1/users/signup')
+        .send({
+          email: 'sandy@gmail.com',


Replace 'sandy@gmail.com' with "sandy@gmail.com" prettier/prettier

hound · 2019-07-09T12:12:31Z

src/tests/controller/auth.spec.js

+    it('Should not allow duplicated user register', done => {
+      chai
+        .request(app)
+        .post('/api/v1/users/signup')


Replace '/api/v1/users/signup' with "/api/v1/users/signup" prettier/prettier

hound · 2019-07-09T12:12:31Z

src/tests/controller/auth.spec.js

+        });
+    });
+
+    it('Should not allow duplicated user register', done => {


Replace 'Should·not·allow·duplicated·user·register' with "Should·not·allow·duplicated·user·register" prettier/prettier

hound · 2019-07-09T12:12:31Z

src/tests/controller/auth.spec.js

+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');
+          expect(response.body.data[0].msg).to.equal(
+            'Password can not be less than 8 characters'


Replace 'Password·can·not·be·less·than·8·characters' with "Password·can·not·be·less·than·8·characters" prettier/prettier

hound · 2019-07-09T12:12:31Z

src/tests/controller/auth.spec.js

+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');
+          expect(response.body.status).to.equal('fail');


Replace 'fail' with "fail" prettier/prettier

hound · 2019-07-09T12:12:31Z

src/tests/controller/auth.spec.js

+        .end((error, response) => {
+          expect(response.status).to.equal(400);
+          expect(response.body).to.have.property('status');
+          expect(response.body).to.have.property('data');


Replace 'data' with "data" prettier/prettier

hound · 2019-07-09T12:12:32Z

src/tests/controller/auth.spec.js

@@ -178,6 +178,72 @@ describe('Auth API endpoints', () => {
        });
    });

+    it('Should not allow invalid password user input', done => {


Replace 'Should·not·allow·invalid·password·user·input' with "Should·not·allow·invalid·password·user·input" prettier/prettier

hound · 2019-07-09T12:12:32Z

src/index.js

@@ -2,17 +2,28 @@ import express from 'express';
 import bodyParser from 'body-parser';
 import swagger from 'swagger-ui-express';
 import logger from 'morgan';
+import passport from 'passport';


Replace 'passport' with "passport" prettier/prettier

hound · 2019-07-09T12:12:32Z

src/helpers/jwt.helper.js

@@ -14,7 +14,7 @@ dotenv.config();
 * @returns {Response} object
 */

-const getToken = user => {
+export const getToken = user => {


Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style

hound · 2019-07-09T12:12:33Z

src/controllers/social.controller.js

+const socialRedirect = async (request, response) => {
+  if (request.user.noEmail) {
+    return Helper.failResponse(response, 400, {
+      message: 'user has no email address'


Replace 'user·has·no·email·address' with "user·has·no·email·address" prettier/prettier

hound · 2019-07-09T12:12:33Z

src/controllers/social.controller.js

+    where: { email: userEmail },
+    defaults: {
+      firstName: names[0] || 'Firstname',
+      lastName: names[1] || 'Lastname',


Replace 'Lastname' with "Lastname" prettier/prettier

hound · 2019-07-09T17:35:09Z

src/controllers/social.controller.js

+  const [user] = await User.findOrCreate({
+    where: { email: userEmail },
+    defaults: {
+      firstName: names[0] || 'Firstname',


Replace 'Firstname' with "Firstname" prettier/prettier

hound · 2019-07-09T17:35:09Z

src/controllers/social.controller.js

+    return done(null, userWithNoEmail);
+  }
+  const userEmail = emails[0].value;
+  const names = displayName ? displayName.split(' ') : ['', ''];


Replace '·')·:·['',·'' with "·")·:·["",·"" prettier/prettier

hound · 2019-07-09T17:35:09Z

src/controllers/social.controller.js

+import { getToken } from '../helpers/jwt.helper';
+import model from '../db/models';
+import Helper from '../services/helper';
+import { hashPassword } from '../services/auth.service';


Replace '../services/auth.service' with "../services/auth.service" prettier/prettier

hound · 2019-07-09T17:35:09Z

src/controllers/social.controller.js

@@ -0,0 +1,63 @@
+import { getToken } from '../helpers/jwt.helper';
+import model from '../db/models';
+import Helper from '../services/helper';


Replace '../services/helper' with "../services/helper" prettier/prettier

hound · 2019-07-09T17:35:09Z

src/controllers/social.controller.js

@@ -0,0 +1,63 @@
+import { getToken } from '../helpers/jwt.helper';
+import model from '../db/models';


Replace '../db/models' with "../db/models" prettier/prettier

hound · 2019-07-09T17:35:10Z

src/config/passportStrategies.js

+import { Strategy as TwitterStrategy } from 'passport-twitter';
+import { Strategy as GoogleStrategy } from 'passport-google-oauth20';
+
+import dotenv from 'dotenv';


Replace 'dotenv' with "dotenv" prettier/prettier

hound · 2019-07-09T17:35:10Z

src/config/passportStrategies.js

+import passport from 'passport';
+import { Strategy as FacebookStrategy } from 'passport-facebook';
+import { Strategy as TwitterStrategy } from 'passport-twitter';
+import { Strategy as GoogleStrategy } from 'passport-google-oauth20';


Replace 'passport-google-oauth20' with "passport-google-oauth20" prettier/prettier

hound · 2019-07-09T17:35:10Z

src/config/passportStrategies.js

@@ -0,0 +1,58 @@
+import passport from 'passport';
+import { Strategy as FacebookStrategy } from 'passport-facebook';
+import { Strategy as TwitterStrategy } from 'passport-twitter';


Replace 'passport-twitter' with "passport-twitter" prettier/prettier

hound · 2019-07-09T17:35:10Z

src/config/passportStrategies.js

@@ -0,0 +1,58 @@
+import passport from 'passport';
+import { Strategy as FacebookStrategy } from 'passport-facebook';


Replace 'passport-facebook' with "passport-facebook" prettier/prettier

hound · 2019-07-09T17:35:10Z

src/config/passportStrategies.js

@@ -0,0 +1,58 @@
+import passport from 'passport';


Replace 'passport' with "passport" prettier/prettier

hound · 2019-07-10T11:57:29Z

src/services/user.service.js

@@ -1,6 +1,6 @@
 import bcrypt from 'bcryptjs';
 import crypto from 'crypto';
-import getToken from '../helpers/jwt.helper';
+import { getToken } from '../helpers/jwt.helper';


Replace '../helpers/jwt.helper' with "../helpers/jwt.helper" prettier/prettier

hound · 2019-07-11T02:36:16Z

src/services/user.service.js

@@ -17,7 +17,7 @@ const { User, Follow } = model;
 export const getAllUsersService = async () => {
  const users = await User.findAll({
    attributes: {
-      exclude: ['password', 'confirmEmailCode']
+      exclude: ['password', 'confirmEmailCode', 'passwordToken']


Replace 'password',·'confirmEmailCode',·'passwordToken' with "password",·"confirmEmailCode",·"passwordToken" prettier/prettier

hound · 2019-07-11T02:36:16Z

src/routes/v1/social.route.js

+    '/google',
+    passport.authenticate('google', { scope: ['email', 'profile'] })
+  )
+  .get('/google/callback', passport.authenticate('google'), socialRedirect);


Replace '/google/callback',·passport.authenticate('google' with "/google/callback",·passport.authenticate("google" prettier/prettier

hound · 2019-07-11T02:36:16Z

src/routes/v1/social.route.js

+router
+  .get(
+    '/google',
+    passport.authenticate('google', { scope: ['email', 'profile'] })


Replace 'google',·{·scope:·['email',·'profile' with "google",·{·scope:·["email",·"profile" prettier/prettier

hound · 2019-07-11T02:36:16Z

src/routes/v1/social.route.js

+
+router
+  .get(
+    '/google',


Replace '/google' with "/google" prettier/prettier

hound · 2019-07-11T02:36:16Z

src/routes/v1/social.route.js

+  .get('/twitter', passport.authenticate('twitter', { scope: ['email'] }))
+  .get(
+    '/twitter/callback',
+    passport.authenticate('twitter', { session: false }),


Replace 'twitter' with "twitter" prettier/prettier

hound · 2019-07-11T02:36:17Z

src/routes/v1/social.route.js

+router
+  .get(
+    '/facebook',
+    passport.authenticate('facebook', {


Replace 'facebook' with "facebook" prettier/prettier

hound · 2019-07-11T02:36:17Z

src/routes/v1/social.route.js

+
+router
+  .get(
+    '/facebook',


Replace '/facebook' with "/facebook" prettier/prettier

hound · 2019-07-11T02:36:17Z

src/routes/v1/social.route.js

@@ -0,0 +1,35 @@
+import express from 'express';
+import passport from 'passport';
+import { socialRedirect } from '../../controllers/social.controller';


Replace '../../controllers/social.controller' with "../../controllers/social.controller" prettier/prettier

hound · 2019-07-11T02:36:17Z

src/routes/v1/social.route.js

@@ -0,0 +1,35 @@
+import express from 'express';
+import passport from 'passport';


Replace 'passport' with "passport" prettier/prettier

hound · 2019-07-11T02:36:18Z

src/routes/v1/social.route.js

@@ -0,0 +1,35 @@
+import express from 'express';


Replace 'express' with "express" prettier/prettier

>-create facebook/google/twitter app and generate Ids and secret keys >-setup middleware(passport)that interfaces with social sites >-create controller function that returns user token after successfull >-write unit tests >-add api documentation using swagger

hound bot reviewed Jul 8, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from 7529bd4 to 5b8d24f Compare July 9, 2019 07:47

hound bot reviewed Jul 9, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from 5b8d24f to d1ccde4 Compare July 9, 2019 11:56

hound bot reviewed Jul 9, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from d1ccde4 to d60b406 Compare July 9, 2019 12:12

hound bot reviewed Jul 9, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from d60b406 to 638f556 Compare July 9, 2019 17:34

hound bot reviewed Jul 9, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from 638f556 to e5526e3 Compare July 10, 2019 11:57

hound bot reviewed Jul 10, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from e5526e3 to 4819c30 Compare July 11, 2019 02:36

hound bot reviewed Jul 11, 2019

View reviewed changes

halimahO force-pushed the ft-enable-social-login-166816103 branch from 4819c30 to 5e8d6ff Compare July 11, 2019 11:30

nedemenang merged commit 9c8b167 into develop Jul 11, 2019


		const tokenMock = 'fake.token';

		sinon.spy(Helper, 'successResponse');

		@@ -0,0 +1,87 @@
		import sinon from 'sinon';
		import sinonChai from 'sinon-chai';


		export default app => {
		app.use('/api/v1/auth/', socialAuth);

		@@ -0,0 +1,63 @@
		import { getToken } from '../helpers/jwt.helper';
		import model from '../db/models';

		@@ -0,0 +1,58 @@
		import passport from 'passport';
		import { Strategy as FacebookStrategy } from 'passport-facebook';

		@@ -0,0 +1,35 @@
		import express from 'express';
		import passport from 'passport';

#166816103 Enable social login #21

#166816103 Enable social login #21

Conversation

halimahO commented Jul 8, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

For facebook: request to be a tester

For twitter

For google

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Questions:

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 8, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

halimahO commented Jul 8, 2019 •

edited

Loading