Add functionality to get all users #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…profiles of existing authors Files modify/create: - modify userController file - modify user routes - modify user.test.js Start #160451510
Pull Request Test Coverage Report for Build 268
💛 - Coveralls |
samdiano
commented
Oct 12, 2018
| @@ -19,7 +19,7 @@ export default class LikeController { | |||
| const dislike = req.params.likeType === 'dislike'; | |||
| // message to be sent to user depending on function performed | |||
| const message = like || dislike ? `you ${req.params.likeType}d the article` | |||
| : 'you disliked the article'; | |||
| : 'you unliked the article'; | |||
There was a problem hiding this comment.
I edited the like controller to fix a bug of not disliking an article after liking that particular article.
…451510/list-users
samdiano
commented
Oct 12, 2018
| @@ -1,6 +1,6 @@ | |||
| [](https://travis-ci.org/andela/phlox-ah) | |||
| [](https://houndci.com) | |||
| [](https://coveralls.io/github/andela/phlox-ah?branch=chore%2F160451494%2Fintegrate-coveralls) | |||
| [](https://coveralls.io/github/andela/phlox-ah?branch=staging) | |||
There was a problem hiding this comment.
here. I changed the targetted branch that the coveralls badge uses to staging
samdiano
commented
Oct 12, 2018
server/models/user.js
Outdated
| @@ -81,7 +81,7 @@ export default (sequelize, DataTypes) => { | |||
| foreignKey: 'userId', | |||
| as: 'likes' | |||
| }); | |||
| User.hasOne(models.Profile, { | |||
| User.hasMany(models.Profile, { | |||
There was a problem hiding this comment.
I changed this relationship to hasMany because I couldn't get sourceKey to work using hasOne. I searched and saw that hasOne does not support sourceKey
samdiano
requested review from
slimsolz,
oladimillion,
onwuvic,
kampkelly and
udochukwu
…451510/list-users
…451510/list-users
s-akinrele
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates functionality for a user to see the list and profiles of existing authors
Description of Task to be completed?
How should this be manually tested?
GET /api/v1/usersGET /api/v1/users/:usernameAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#160451510