Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Article Preference Test #49

Merged
merged 6 commits into from
Oct 26, 2018

Conversation

oladimillion
Copy link
Contributor

What does this PR do?

This PR add test cases to users article preference

Description of Task to be completed?

  • add test cases to users article preference

How should this be manually tested?

run npm test

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#161250004

Screenshots (if appropriate)

N/A

Questions:

N/A

  Files modify/create:
  - Modify article controller
  - Modify user controller
  - Modify user model
  - Modify category model

Finishes #161250004
Modify route name
@kampkelly kampkelly temporarily deployed to phlox-ah-staging-pr-49 October 24, 2018 11:13 Inactive
server/tests/preferences.test.js Outdated Show resolved Hide resolved
server/tests/preferences.test.js Show resolved Hide resolved
server/tests/preferences.test.js Show resolved Hide resolved
server/tests/preferences.test.js Outdated Show resolved Hide resolved
server/tests/preferences.test.js Outdated Show resolved Hide resolved
server/tests/preferences.test.js Outdated Show resolved Hide resolved
@oladimillion oladimillion force-pushed the chore/161250004/users-article-preference-test branch from 460ebb2 to 1f46a7b Compare October 24, 2018 11:15
@kampkelly kampkelly temporarily deployed to phlox-ah-staging-pr-49 October 24, 2018 11:15 Inactive
@coveralls
Copy link

coveralls commented Oct 24, 2018

Pull Request Test Coverage Report for Build 466

  • 14 of 15 (93.33%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 88.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/controllers/userController.js 4 5 80.0%
Totals Coverage Status
Change from base Build 462: 0.04%
Covered Lines: 1127
Relevant Lines: 1247

💛 - Coveralls

@s-akinrele s-akinrele merged commit aa2d4e5 into staging Oct 26, 2018
@s-akinrele s-akinrele deleted the chore/161250004/users-article-preference-test branch October 26, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants