Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164489780 Verify user signed up with email #29

Merged
merged 12 commits into from
Apr 18, 2019

Conversation

jnkindi
Copy link
Contributor

@jnkindi jnkindi commented Apr 16, 2019

What does this PR do?

  • Sends verification email and verifies account

Description of Task to be completed?

  • On signup, an email is sent to the user with a URL, when the user clicks it. He/She is directly verified.

How should this be manually tested?

  • On signup, you can check for an email.

Any background context you want to provide?

  • None

What are the relevant pivotal tracker stories?

  • 164489780

Screenshots (if appropriate)

Screen Shot 2019-04-16 at 10 58 03

Screen Shot 2019-04-16 at 10 57 25

Questions:

  • None

@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 09:00 Inactive
Copy link
Contributor

@cyrielo cyrielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is too large, consider splitting the works

@cyrielo
Copy link
Contributor

cyrielo commented Apr 16, 2019

You would also need to rebase to have the latest changes

@jnkindi jnkindi force-pushed the ft-send-verification-email-164489780 branch from e3bfb61 to e9207df Compare April 16, 2019 10:22
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 10:22 Inactive
@jnkindi
Copy link
Contributor Author

jnkindi commented Apr 16, 2019

@cyrielo, I had checkout from an unmerged develop but am fixing it.

@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 10:37 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 11:01 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 14:57 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 15:16 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 15:40 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 18:37 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 16, 2019 18:44 Inactive
@jnkindi jnkindi force-pushed the ft-send-verification-email-164489780 branch from 3f7b190 to e005657 Compare April 17, 2019 07:41
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 17, 2019 07:41 Inactive
@jnkindi jnkindi force-pushed the ft-send-verification-email-164489780 branch from e005657 to e5e3748 Compare April 17, 2019 07:42
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 17, 2019 07:43 Inactive
@jnkindi jnkindi force-pushed the ft-send-verification-email-164489780 branch from e5e3748 to fcb0421 Compare April 17, 2019 07:44
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 17, 2019 07:44 Inactive
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-29 April 17, 2019 09:58 Inactive
@Inclet Inclet requested a deployment to strikers-ah-backend-stag-pr-29 April 18, 2019 09:19 Abandoned
@cyrielo cyrielo merged commit 8d5a877 into develop Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants