-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#164489780 Verify user signed up with email #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrielo
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is too large, consider splitting the works
You would also need to rebase to have the latest changes |
jnkindi
force-pushed
the
ft-send-verification-email-164489780
branch
from
April 16, 2019 10:22
e3bfb61
to
e9207df
Compare
@cyrielo, I had checkout from an unmerged develop but am fixing it. |
jnkindi
force-pushed
the
ft-send-verification-email-164489780
branch
from
April 17, 2019 07:41
3f7b190
to
e005657
Compare
jnkindi
force-pushed
the
ft-send-verification-email-164489780
branch
from
April 17, 2019 07:42
e005657
to
e5e3748
Compare
jnkindi
force-pushed
the
ft-send-verification-email-164489780
branch
from
April 17, 2019 07:44
e5e3748
to
fcb0421
Compare
frankhn
requested review from
mwibutsa,
mystere10,
cyrielo,
frankhn,
dniwemugisha and
Inclet
April 17, 2019 08:28
jnkindi
force-pushed
the
ft-send-verification-email-164489780
branch
from
April 17, 2019 10:00
73dac30
to
9ebf7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
164489780
Screenshots (if appropriate)
Questions: