#161178600 Fix admin request success message and move requestMock file #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 12, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
Pull Request Test Coverage Report for Build 318
💛 - Coveralls |
phemonick
approved these changes
Oct 15, 2018
nouwatinjacob
requested review from
phemonick,
kenware and
Lumexralph
and removed request for
phemonick and
Lumexralph
kenware
approved these changes
Oct 15, 2018
nouwatinjacob
added
Ready for merge
nouwatinjacob
force-pushed
the
bg-fix-request-bug-161178600
branch
from
998203e
to
9307f4e
Compare
houndci-bot
reviewed
Oct 17, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
- change success message when admin request is successful - moved requestMock.js file to mock data folder [Fixes #161178600]
nouwatinjacob
force-pushed
the
bg-fix-request-bug-161178600
branch
from
9307f4e
to
0ab55f0
Compare
houndci-bot
reviewed
Oct 17, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change admin request success message and move requestMock file to mock data folder
Description of Task to be completed?
How should this be manually tested?
N/A
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#161178600
Screenshots or gifs (if appropriate)
N/A
Questions:
N/A