#169258648 User can search trip requests by preference #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
nziokaivy
force-pushed
the
ft-search-functionality-169258648
branch
from
869934a
to
1fb90f3
Compare
nziokaivy
force-pushed
the
ft-search-functionality-169258648
branch
from
1fb90f3
to
2a7355a
Compare
nziokaivy
added
Ready for review
nziokaivy
requested review from
william000000,
julietezekwe,
NiyoEric,
hezronkimutai and
victkarangwa
victkarangwa
requested changes
Dec 12, 2019
nziokaivy
force-pushed
the
ft-search-functionality-169258648
branch
3 times, most recently
from
4581f9f
to
fb4014a
Compare
ivymwende
added
feedback implemented
and removed
Ready for review
victkarangwa
approved these changes
Dec 12, 2019
hezronkimutai
requested changes
Dec 12, 2019
There was a problem hiding this comment.
Nice job @ivymwende , I left a comment, please view it and we will be good to go.
| return Response.errorMessage(req, res, 'You provided an invalid search query key(s) parameter.Your search key should be either originId, destinationId, startDate, returnDate, firstName, status, or tripType', 400); | ||
| } | ||
|
|
||
| if (query.originId === '' || query.destinationId === '' || query.startDate === '' || query.returnDate === '' || query.firstName === '' || query.tripType === '') { |
There was a problem hiding this comment.
Hi @ivymwende , lets make this line shorter ie
if (query.originId === '' || query.destinationId === ''
|| query.startDate === '' || query.returnDate === ''
|| query.firstName === '' || query.tripType === ''
)
| }); | ||
|
|
||
|
|
||
| export default query; |
There was a problem hiding this comment.
Wow! this file looks nice.
- Add tests - Add verify token validation - Add user is verified validation - Add validate query parameters validation middleware - Add search query parameter query function - Add search controller - Add route API documentation [Finishes #169258648]
nziokaivy
force-pushed
the
ft-search-functionality-169258648
branch
from
fb4014a
to
1988f65
Compare
hezronkimutai
approved these changes
Dec 12, 2019
william000000
approved these changes
Dec 12, 2019
Comment on lines
+19
to
+21
| const searchingTrips = await CommonQueries.findAll( | ||
| trips, commonSearchQueries(query, req.user.id) | ||
| ); |
There was a problem hiding this comment.
Wonderful nested queries! That's great.
Comment on lines
+7
to
+29
| const query = (searchQueryParams, id) => ({ | ||
| where: { | ||
| ...searchQueryParams.startDate && { | ||
| startDate: { | ||
| [Op.iLike]: `%${searchQueryParams.startDate.trim()}%` | ||
| } | ||
| }, | ||
| ...searchQueryParams.returnDate && { | ||
| returnDate: { | ||
| [Op.iLike]: `%${searchQueryParams.returnDate.trim()}%` | ||
| } | ||
| }, | ||
| ...searchQueryParams.originId && { | ||
| originId: { | ||
| [Op.eq]: parseInt((searchQueryParams.originId), 10) | ||
| } | ||
| }, | ||
| ...searchQueryParams.destinationId && { | ||
| destinationId: { | ||
| [Op.eq]: parseInt((searchQueryParams.destinationId), 10) | ||
| } | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I like the way you come up with this queries.
william000000
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Great Job @nziokaivy. I have lost a mistake that you might have done.
julietezekwe
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a user, I should be able to use the search component so, I can easily retrieve records from both the request and approval table
Description of Task to be completed?
How should this be manually tested?
git clone https://github.com/andela/team-odd-bn-backend.gitgit checkout ft-search-functionality-169258648Any background context you want to provide?
As requests and approval tables grow, it should be easy to find requests through the search functionality
What are the relevant pivotal tracker stories?
#169258648
Screenshots (if appropriate)
Search by originId
Search by destinationId
Search by trip type
Search by status
Search by trip owner(by their first name)
Questions: