Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169817542 Google and Facebook authentication #27

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

gadishimwe
Copy link
Contributor

@gadishimwe gadishimwe commented Dec 23, 2019

What does this PR do?

Add Google and Facebook authentication feature

Description of Task to be completed?

  • Add google authentication middleware and controller with passport
  • Add facebook authentication middleware and controller with passport

How should this be manually tested?

$ git clone https://github.com/andela/the_spinners-backend.git
$ cd the_spinners-backend
$ git checkout  ft-login-with-google-facebook-auth-169817542
$ npm run dev

then visit this route in browser localhost:3000/api/auth/google for google and localhost:3000/api/auth/facebook for facebook
after that, you will be required to grant access to Barefoot Nomad and to sign in if you're currently not

What are the relevant pivotal tracker stories?

#169817542

Screenshots

Screen Shot 2019-12-23 at 14 19 02

Screen Shot 2019-12-23 at 14 18 31

@gadishimwe gadishimwe force-pushed the ft-login-with-google-facebook-auth-169817542 branch 3 times, most recently from fd957d8 to a5d9c98 Compare December 27, 2019 09:46
- Add google authentication middleware and controller with passport
- Add facebook authentication middleware and controller with passport
- Add tests for feature

[starts #169817542]
@gadishimwe gadishimwe force-pushed the ft-login-with-google-facebook-auth-169817542 branch from a5d9c98 to 3449b95 Compare December 27, 2019 09:50
Copy link
Collaborator

@katunold katunold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katunold katunold merged commit ae0db8f into develop Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants