#159987730 Users should be able to like or dislike comment made on an article. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 349
💛 - Coveralls |
lauragift21
suggested changes
Sep 11, 2018
emekafredy
force-pushed
the
ft-create-comment-likes-endpoint-159987730
branch
2 times, most recently
from
162d1cf
to
c9028e0
Compare
|
@lauragift21 This has been resolved |
aknwosu
reviewed
Sep 11, 2018
server/controllers/comments.js
Outdated
| } | ||
|
|
||
| /** | ||
| * @description get number of likes and dislikes in an article |
There was a problem hiding this comment.
Thanks. I will correct this
aknwosu
reviewed
Sep 11, 2018
server/controllers/comments.js
Outdated
| if (commentReaction.reaction === '1') { | ||
| commentReactions.likes += 1; | ||
| } else if (commentReaction.reaction === '0') { | ||
| commentReactions.dislikes += 1; |
There was a problem hiding this comment.
a better implementation is to find all where reaction === 0 or reaction === 1 and then total number of likes would be the length of the returned value.
There was a problem hiding this comment.
Thank you. I will also work on this
aknwosu
suggested changes
Sep 11, 2018
…rticles - define CommentLikes Model and its association with comments and users. - write unit tests for comment like model and route. - create endpoints for authenticated users to like or dislike comments made on articles. [Delivers #159987730]
…rticles - redefine model to store integers (0, 1) for dislikes and likes - write endpoint to get all reactions of a comment [Delivers #159987730]
emekafredy
force-pushed
the
ft-create-comment-likes-endpoint-159987730
branch
from
3a9dd91
to
b6f2003
Compare
…rticles - Refactor code on getting the number of likes and dislikes in a comment. - Define an endpoint to check if the current logged in user already liked or disliked a comment. [Delivers #159987730]
emekafredy
force-pushed
the
ft-create-comment-likes-endpoint-159987730
branch
from
b6f2003
to
fcbb03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create endpoints for to like or dislike article comments
Description of Task to be completed?
Create CommentLike model and migration file
Write unit tests for feature
Create endpoint
POST api/articles/<article_slug>/comments/<commentId>/likePOST api/articles/<article_slug>/comments/<commentId>/dislikeHow should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
159987730