#159987737 Comments should be able to track edit history #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch all comments and replies for an article and include user informantion. - update comment models: add validations.
In order to track comment history, we would need to have a copy of the comment on each edit. Also for future queries, we've added a column "isEdited" which is a boolean to know if the comment has been edited before and to determine whether or not to fetch it's history. - add isEdited column to comment table - generate commentHistory table and migrations - add relationship between both tables
Allow users update, their comments, and also track the edit history of each update. - add updateComment method - prevent users from updating other users' comments - add relevant tests - use hooks to update commentHistory model - return updated comment with each update
Users can comment and edit comments. This method fetches the comment edit history. - Add relevant tests - Add getCommentEdits method. [Delivers #159987737]
Pull Request Test Coverage Report for Build 402
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
implement the ability to track comment edit history.
Description of Task to be completed?
Allow users update, their comments, and also track the edit history of each update.
How should this be manually tested?
Run
npm run migrateRun
npm run start:devsend a
POSTrequest to/api/articles/to create an articlesend a
POSTrequest to/api/articles/:slug/commentsto create a commentsend a
PUTrequest to/api/articles/:slug/comments/:commentIdto update the commentsend a
GETrequest to/api/articles/:slug/comments/:commentId/editsto retrieve comment editsWhat are the relevant pivotal tracker stories?
#159987737