This repository has been archived by the owner on May 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 12, 2018
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 12, 2018 15:33
6cc4218
to
76f1f2b
Compare
Pull Request Test Coverage Report for Build 496
💛 - Coveralls |
sulenchy
requested review from
mbilesanmi,
augustineezinwa,
KvNGCzA,
darthrighteous and
tersoo-atsen
November 12, 2018 15:38
darthrighteous
requested a deployment
to
valinor-ah-backend-stagi-pr-46
November 12, 2018 15:42
Abandoned
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 12, 2018 15:42
Inactive
sulenchy
changed the title
feat(coment-on-article): add comment on an article
#161291011 Add comment on an article
Nov 12, 2018
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 06:03
76f1f2b
to
90b9065
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 06:04
Inactive
augustineezinwa
suggested changes
Nov 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you validated for an article that does not exist. What happens if I try to add a comment to a non-existent article with an id 1000? what happens if the id is not a number? Do well to cover the above edge cases.
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 10:26
Inactive
houndci-bot
reviewed
Nov 13, 2018
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 11:26
3207997
to
2dacb46
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 11:27
Inactive
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 13:20
2dacb46
to
0410c8f
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 13:21
Inactive
houndci-bot
reviewed
Nov 13, 2018
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 13:24
0410c8f
to
a76dac5
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 13:24
Inactive
- add addCommentOnArticle method - add addCommentOnArticle route - test the method [Finishes #161291011]
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 14:01
a76dac5
to
264deec
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 14:01
Inactive
KvNGCzA
reviewed
Nov 13, 2018
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 15:01
264deec
to
f31e94c
Compare
darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-46
November 13, 2018 15:01
Inactive
- implement separation of concern [Finishes #161291011]
sulenchy
force-pushed
the
feature/161291011/comment-on-article
branch
from
November 13, 2018 15:15
f31e94c
to
c2955fe
Compare
augustineezinwa
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add comment on an article
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#161291011
Screenshots (if appropriate)
Questions:
N/A