Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

#161291025 Add like dislike comment feature #55

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

sulenchy
Copy link
Contributor

@sulenchy sulenchy commented Nov 14, 2018

What does this PR do?

Add like dislike comment API endpoint

Description of Task to be completed?

  • add likeOrDislikeComment controller
  • add likeOrDislikeComment route
  • test likeOrDislikeComment endpoint
  • refactor validateArticleId middleware

How should this be manually tested?

  • Use postman to signup using https://valinor-ah-backend-stagi-pr-55.herokuapp.com/api/v1/users/signup
  • Get the token and add article using https://valinor-ah-backend-stagi-pr-55.herokuapp.com/api/v1/articles
  • Get the token and comment on the article using https://valinor-ah-backend-stagi-pr-55.herokuapp.com/api/v1/articles/:articleId/comments. Where :articleId is the id of the article
  • Get the token and like or dislike the comment using https://valinor-ah-backend-stagi-pr-55.herokuapp.com/api/v1/articles/:articleId/comments/:commentId/reaction/dislike

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#161291025

Screenshots (if appropriate)

screen shot 2018-11-15 at 5 11 41 pm

screen shot 2018-11-15 at 5 12 15 pm

screen shot 2018-11-15 at 5 12 35 pm

screen shot 2018-11-15 at 5 12 50 pm

screen shot 2018-11-15 at 5 13 06 pm

Questions:

N/A

@darthrighteous darthrighteous temporarily deployed to valinor-ah-backend-stagi-pr-55 November 14, 2018 20:30 Inactive
@coveralls
Copy link

coveralls commented Nov 14, 2018

Pull Request Test Coverage Report for Build 566

  • 32 of 33 (96.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/middlewares/validateResourceId.js 16 17 94.12%
Totals Coverage Status
Change from base Build 542: -0.04%
Covered Lines: 597
Relevant Lines: 619

💛 - Coveralls

@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 64db570 to 6e2cb2c Compare November 15, 2018 05:14
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 05:14 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 6e2cb2c to 69cad63 Compare November 15, 2018 05:23
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 05:23 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 69cad63 to 833ac02 Compare November 15, 2018 05:56
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 05:56 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 833ac02 to 75832eb Compare November 15, 2018 06:31
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 06:32 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 75832eb to c9f6285 Compare November 15, 2018 07:35
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 07:35 Inactive
@darthrighteous darthrighteous temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 07:41 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from c9f6285 to b958a57 Compare November 15, 2018 07:43
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 07:43 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from b958a57 to 9dc1e61 Compare November 15, 2018 11:46
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 11:46 Inactive
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 9dc1e61 to 2bb0428 Compare November 15, 2018 13:03
@darthrighteous

This comment has been minimized.

- add likeOrDislikeComment controller
- add likeOrDislikeComment route
- test likeOrDislikeComment endpoint
- refactor validateArticleId middleware

[Finishes #161291025]
@sulenchy sulenchy force-pushed the feature/161291025/like-dislike-comment branch from 2bb0428 to a1ba98f Compare November 15, 2018 15:30
@sulenchy sulenchy temporarily deployed to valinor-ah-backend-stagi-pr-55 November 15, 2018 15:30 Inactive
@mbilesanmi mbilesanmi merged commit 0716506 into develop Nov 15, 2018
@mbilesanmi mbilesanmi deleted the feature/161291025/like-dislike-comment branch November 15, 2018 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants