166573650 Fix get all exercises #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wekesa931
force-pushed
the
bg-#166573650-fix-fetch-exercises
branch
from
d740503
to
85f8d59
Compare
- Fix the fetch all exercise endpoint which was not working as expected [Fixes #166573650]
wekesa931
force-pushed
the
bg-#166573650-fix-fetch-exercises
branch
from
85f8d59
to
8557107
Compare
wangonya
suggested changes
Jun 12, 2019
There was a problem hiding this comment.
Kindly fix your PR description.
Steps to reproduceshould be what you have to do to experience the bug (e.g access a certain endpoint)Expectedshould be how the app should be working ideally (e.g a list of all exercises should be returned)Actualshould be what is actually happening as a result of the bug (e.g no exercises are being returned)
willeswa
suggested changes
Jun 12, 2019
|
LGTM |
ceexon
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the fetch all exercise endpoint which was not working as expected
Steps to reproduce
After installation and the app runs, navigate to the endpoint:
http://127.0.0.1:8000/api/v2/exercise/and make a get request.Expected
All exercises should be displayed.
Actual
The exercises are not displayed as expected.