166152325 Adds relation between workout log and workout session #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justMuriithi
added
🚧 Work in Progress
justMuriithi
requested review from
bencyn,
martinMutuma,
Tevinthuku,
misocho and
Kimaiyo077
martinMutuma
approved these changes
Jun 14, 2019
bencyn
approved these changes
Jun 14, 2019
Tevinthuku
approved these changes
Jun 14, 2019
misocho
approved these changes
Jun 14, 2019
- Adds field session to workoutlog - Adds tests to show relationship between workoutlog and workoutsession [Delivers #166152325]
justMuriithi
force-pushed
the
story/166152325-workout-log-session-relation
branch
from
5e48e85
to
a53cc6e
Compare
michael-basweti
approved these changes
Jun 14, 2019
Coverage is well taken care of as it ought to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Adds a relation between workout log and workout session
Description
Right now the workout logs and the workout session are only linked through the date (for sessions this value is unique and enforced by the DB). This presents in some places a problem since it's not possible to just follow a foreign key relationship with the ORM like in other places.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Acceptance Criteria:
Checklist:
PT stories
#166152325
Screenshots
As can be viewed below, once a workout log is created, it is auto-populated with the respective session id. This can be verified by browsing the database with a tool like
pgAdmin