166152326 Allows comparison of members #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 18, 2019
justMuriithi
force-pushed
the
story/166152326-comparison-of-members
branch
from
24a2fd5
to
826e215
Compare
houndci-bot
reviewed
Jun 18, 2019
justMuriithi
added
the
🚧 Work in Progress
justMuriithi
force-pushed
the
story/166152326-comparison-of-members
branch
from
826e215
to
db33821
Compare
houndci-bot
reviewed
Jun 18, 2019
justMuriithi
force-pushed
the
story/166152326-comparison-of-members
branch
2 times, most recently
from
d133e79
to
da3bf0d
Compare
houndci-bot
reviewed
Jun 18, 2019
justMuriithi
force-pushed
the
story/166152326-comparison-of-members
branch
2 times, most recently
from
bba54af
to
dafd3a1
Compare
houndci-bot
reviewed
Jun 19, 2019
- Adds a means to compare weight data of 2 members - Assigns comparison functionality to gym manager [Delivers #166152326]
justMuriithi
force-pushed
the
story/166152326-comparison-of-members
branch
from
dafd3a1
to
aa344d4
Compare
justMuriithi
added
👍 ready
justMuriithi
requested review from
martinMutuma,
misocho,
Tevinthuku,
Kimaiyo077 and
bencyn
Tevinthuku
approved these changes
Jun 19, 2019
misocho
approved these changes
Jun 19, 2019
Kimaiyo077
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
I was able to compare weight entries of two users graphically which can be helpful data. Nice work @justMuriithi
michael-basweti
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
This PR allows for the comparison of members' weight data
Description
When two users are training together it would be useful to see a comparison of some sorts. Two graphs showing the users' weight data gives a good visual impression of the comparison
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Can This Be Manually Tested?
To be able to test the feature, check out the branch
story/166152326-comparison-of-membersand thenpython manage.py runserver.Login as a gym manager
Navigate to the URL
http://127.0.0.1:8000/en/gym/<gym_id>/memberson your browserAcceptance Criteria:
Checklist:
PT stories
#166152326