#159396311 Configure heroku deployment #1

solnsubuga · 2018-07-30T18:27:03Z

What does this PR do?

This PR sets up deployment on heroku.

Description of Task to be completed?

Configure application for deployment to staging area
Enable automatic deployment of develop branch to staging when CI passes.

How should this be manually tested?

Visit the deployed application here or follow steps below to deploy to your own app:
Create application on Heroku add postgres dyno
Set config variable DB to be heroku
Set your python buildpack to be https://github.com/solnsubuga/heroku-buildpack-python
Add heroku/nodejs buildpack as well.
Deploy this branch ft-heroku-deployment-159396311 to your app.

What are the relevant pivotal tracker stories?

#159396311

Screenshots (if appropriate)

lym · 2018-07-31T08:38:02Z

@solnsubuga The assets (JavaScript/CSS/Images) don't appear to be working on the deployed instance.

solnsubuga · 2018-07-31T11:01:44Z

@lym static files are removed after deploying. Am looking for a fix.

solnsubuga · 2018-07-31T13:00:33Z

@lym I have fixed the assets issue. Here is the deployed instance: https://wger-bs-staging.herokuapp.com/en/software/features

lym · 2018-08-01T09:51:35Z

@solnsubuga The link to the story, in your PR description is broken. Please rectify this.

lym · 2018-08-01T09:56:25Z

.travis.yml

@@ -15,16 +15,15 @@ sudo: false
 # Python versions to test
 python:
  - "2.7"
-  - "3.4"


Why did you disable testing against Python3.4?

lym · 2018-08-01T09:59:20Z

.travis.yml

-  - TEST_MOBILE=True  DB=postgresql TRAVIS_NODE_VERSION="4"
-  - TEST_MOBILE=True  DB=sqlite     TRAVIS_NODE_VERSION="4"
-  - TEST_MOBILE=False DB=postgresql TRAVIS_NODE_VERSION="4"
-  - TEST_MOBILE=False DB=sqlite     TRAVIS_NODE_VERSION="4"


Why are you getting rid of these?

lym · 2018-08-01T10:00:49Z

.travis.yml

-
-  # Javascript linting
-  - gulp lint
-


You need to add these checks back.

lym · 2018-08-01T10:02:38Z

requirements.txt

+python-decouple==3.1
+dj-database-url==0.5.0
+psycopg2-binary==2.7.5
+whitenoise


Please lock whitenoise to a specific version.

lym · 2018-08-01T10:03:51Z

settings.py

+TEMPLATES[0]['OPTIONS']['debug'] = True
+
+ADMINS = (
+    ('Your name', 'your_email@example.com'),


Add yourself as an admin here.

lym · 2018-08-01T10:05:26Z

settings.py

+    }
+
+# Make this unique, and don't share it with anybody.
+SECRET_KEY = 'yu==q%107qo(dm#m%x75(wo$6!l!uo!gskog6**kvssg^%(8_h'


We should store and retrieve this from and environment variable.

lym · 2018-08-01T10:07:15Z

wger/manager/views/pdf.py

@@ -28,7 +28,8 @@
 from wger.utils.pdf import styleSheet
 from wger.utils.pdf import render_footer

-from reportlab.lib.pagesizes import A4, cm
+from reportlab.lib.pagesizes import A4
+from reportlab.lib.units import cm


Are changes to this file relevant to your task?

That change was necessary in order to run the application. It was bug, variable cm was being imported from the wrong package.

lym · 2018-08-01T12:27:04Z

wger/manager/views/pdf.py

@@ -28,7 +28,8 @@
 from wger.utils.pdf import styleSheet
 from wger.utils.pdf import render_footer

-from reportlab.lib.pagesizes import A4, cm
+from reportlab.lib.pagesizes import A4
+from reportlab.lib.units import cm


lym · 2018-08-01T12:32:07Z

wger/settings_global.py

@@ -28,6 +28,9 @@
 BASE_DIR = os.path.abspath(os.path.dirname(__file__))
 SITE_ROOT = os.path.realpath(os.path.dirname(__file__))

+SECRET_KEY = os.environ.get(
+    "SECRET_KEY", 'M34Ivcwrw34343Jr1hp7YzS29nVCiWqT4MgpxHSfiXNzPI5oSP8uLYXOIZ')


Don't add a default. Let's force everyone to retrieve it from the environment. This way, all devs will have to set it by themselves and then we also have to update things like TravisCI and Heroku to include this environment variable.

This is the standard practice for things as sensitive as this.

lym · 2018-08-01T17:16:21Z

LGTM

solnsubuga requested review from lym, RrNn, wasswa-derick, Yiga-fred and ja-odur July 30, 2018 18:28

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 08:40 Inactive

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 09:20 Inactive

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 1e6e813 to 02dcb84 Compare July 31, 2018 09:54

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 10:21 Inactive

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 10:26 Inactive

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 02dcb84 to 06e83a7 Compare July 31, 2018 10:42

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 11:02 Inactive

solnsubuga had a problem deploying to wger-bs-staging July 31, 2018 11:51 Failure

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 11:52 Inactive

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 06e83a7 to 792615b Compare July 31, 2018 12:36

solnsubuga temporarily deployed to wger-bs-staging July 31, 2018 12:48 Inactive

lym reviewed Aug 1, 2018

View reviewed changes

.travis.yml

# Javascript linting

- gulp lint

Copy link

Contributor

lym Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add these checks back.

lym reviewed Aug 1, 2018

View reviewed changes

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 10:42 Inactive

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 792615b to c717f74 Compare August 1, 2018 10:54

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 10:54 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 10:56 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 11:04 Failure

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 11:08 Inactive

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 11:15 Failure

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 11:27 Inactive

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 11:37 Inactive

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 11:42 Inactive

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 11:51 Inactive

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 11:59 Failure

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 12:05 Inactive

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 7e400ac to d794927 Compare August 1, 2018 12:14

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 12:19 Inactive

lym reviewed Aug 1, 2018

View reviewed changes

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from d794927 to e410388 Compare August 1, 2018 13:46

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 13:52 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 14:00 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 14:06 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 14:13 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 14:24 Failure

solnsubuga had a problem deploying to wger-bs-staging August 1, 2018 14:52 Failure

[Feature #159396311] Configure heroku deployment

8909bfb

solnsubuga force-pushed the ft-heroku-deployment-159396311 branch from 2c4fb64 to 8909bfb Compare August 1, 2018 15:09

solnsubuga temporarily deployed to wger-bs-staging August 1, 2018 15:10 Inactive

lym merged commit 1b85660 into develop Aug 1, 2018

RrNn pushed a commit that referenced this pull request Aug 2, 2018

Merge pull request #1 from andela/ft-heroku-deployment-159396311

f578c12

RrNn pushed a commit that referenced this pull request Aug 2, 2018

Merge pull request #1 from andela/ft-heroku-deployment-159396311

30ac700

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#159396311 Configure heroku deployment #1

#159396311 Configure heroku deployment #1

solnsubuga commented Jul 30, 2018 •

edited

Loading

lym commented Jul 31, 2018

solnsubuga commented Jul 31, 2018

solnsubuga commented Jul 31, 2018

lym commented Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

solnsubuga Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018

lym Aug 1, 2018 •

edited

Loading

lym commented Aug 1, 2018

#159396311 Configure heroku deployment #1

#159396311 Configure heroku deployment #1

Conversation

solnsubuga commented Jul 30, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

lym commented Jul 31, 2018

solnsubuga commented Jul 31, 2018

solnsubuga commented Jul 31, 2018

lym commented Aug 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lym Aug 1, 2018 • edited Loading

Choose a reason for hiding this comment

lym commented Aug 1, 2018

solnsubuga commented Jul 30, 2018 •

edited

Loading

lym Aug 1, 2018 •

edited

Loading