Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows Support #17

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Added Windows Support #17

merged 1 commit into from
Nov 13, 2018

Conversation

daun-io
Copy link
Contributor

@daun-io daun-io commented Nov 12, 2018

If the platform is Windows and nvidia-smi could not be found from the environment path, try to find it from system drive with default installation path

If the platform is Windows and nvidia-smi could not be found from the environment path, try to find it from system drive with default installation path
@duch94
Copy link

duch94 commented Nov 12, 2018

Cool! That is exactly what i needed

@daun-io
Copy link
Contributor Author

daun-io commented Nov 12, 2018

Cool! That is exactly what i needed

Thanks :)

@duch94
Copy link

duch94 commented Nov 12, 2018

Also i manually patched my 1.3.0 package with this code and it actually works on Windows now

@anderskm
Copy link
Owner

Thank you for submitting this pull request.
It seems like a nice and lightweight solution to the problem.

@anderskm anderskm merged commit 784984f into anderskm:master Nov 13, 2018
@anderskm anderskm mentioned this pull request Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants