Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan de indicaciones - Control de hs (frecuencia) para ejecución de una indicación #2779

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Plan de indicaciones - Control de hs (frecuencia) para ejecución de una indicación #2779

merged 2 commits into from
Mar 3, 2023

Conversation

negro89
Copy link
Contributor

@negro89 negro89 commented Nov 15, 2022

Requerimiento

https://proyectos.andes.gob.ar/browse/IN-508

Funcionalidad desarrollada

  1. Avisa al usuario al momento de registrar un nuevo evento en estado 'realizado' si no coincide con la indicación.
  2. Agrega formulario para controlar campos requeridos y boton guardar.

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@negro89 negro89 requested review from a team as code owners November 15, 2022 12:17
@MarianoCampetella MarianoCampetella added the changes requested Se solicitaron cambios label Nov 17, 2022
@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 7964
CYPRESS RUN: 7157
TEST START: 2022-11-17T15:58:21.169Z
TOTAL: 327
SUCCESS: 317
FAIL: 9
SKIPPED: 1
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 7965
CYPRESS RUN: 7158
TEST START: 2022-11-17T16:20:52.047Z
TOTAL: 406
SUCCESS: 398
FAIL: 7
SKIPPED: 1

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 7966
CYPRESS RUN: 7159
TEST START: 2022-11-17T16:38:52.397Z
TOTAL: 343
SUCCESS: 309
FAIL: 33
SKIPPED: 1

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 7967
CYPRESS RUN: 7160
TEST START: 2022-11-17T17:50:22.300Z
TOTAL: 397
SUCCESS: 387
FAIL: 9
SKIPPED: 1

@MarianoCampetella MarianoCampetella removed the changes requested Se solicitaron cambios label Nov 18, 2022
@negro89 negro89 force-pushed the IN-508 branch 3 times, most recently from 532fd01 to affa72d Compare November 22, 2022 13:47
@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 7989
CYPRESS RUN: 7182
TEST START: 2022-11-22T14:16:34.368Z
TOTAL: 373
SUCCESS: 367
FAIL: 5
SKIPPED: 1

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 7991
CYPRESS RUN: 7184
TEST START: 2022-11-22T16:56:37.991Z
TOTAL: 406
SUCCESS: 397
FAIL: 8
SKIPPED: 1

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8129
CYPRESS RUN: 7316
TEST START: 2022-12-13T16:02:02.604Z
TOTAL: 406
SUCCESS: 403
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8130
CYPRESS RUN: 7317
TEST START: 2022-12-13T16:52:06.514Z
TOTAL: 406
SUCCESS: 404
FAIL: 0
SKIPPED: 2

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Dec 13, 2022
@MCele MCele added the publicar label Dec 22, 2022
@negro89
Copy link
Contributor Author

negro89 commented Dec 26, 2022

Actualizado al 26/12. Funcionalidad ok.

AgosLizzi
AgosLizzi requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@AgosLizzi AgosLizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lautii, vi un par de errores sobre la consola, Siempre en momento diferentes en la navegación. Te los dejo:
2023-01-25 (9)
2023-01-25 (10)
2023-01-25 (11)

@negro89
Copy link
Contributor Author

negro89 commented Feb 14, 2023

@AgosLizzi ese error esta cargado para tratarse en otra tarea, ya que viene desde los inicios del plan. El otro error al parecer es consecuencia del primero.
https://proyectos.andes.gob.ar/browse/IN-518

@negro89 negro89 merged commit 681eb59 into master Mar 3, 2023
@negro89 negro89 deleted the IN-508 branch March 3, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgosLizzi AgosLizzi AgosLizzi approved these changes

@MarianoCampetella MarianoCampetella MarianoCampetella approved these changes

@MCele MCele Awaiting requested review from MCele MCele is a code owner automatically assigned from andes/code-review

Assignees
No one assigned
Labels
Aprobado has_conflicts publicar test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@negro89 @silviroa @MarianoCampetella @AgosLizzi @MCele