Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONIT - Actualización de ABM #61

Merged
merged 2 commits into from
Mar 6, 2024
Merged

MONIT - Actualización de ABM #61

merged 2 commits into from
Mar 6, 2024

Conversation

ma7payne
Copy link
Contributor

Requerimiento

https://proyectos.andes.gob.ar/browse/MONIT-51

Funcionalidad desarrollada

  1. Repara búsqueda de concepto. Al ingresar ConceptID se muestran los resultados de busqueda independientemente de que se haya ingresado algun valor en el campo Term.
  2. Al crear un nuevo concepto turneable, si este ya existe en la BD, no permite volver a guardarlo y se muestra un mensaje de error.
  3. Se remueve la implementación del método de eliminación de concepto turneable.

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@ma7payne ma7payne requested review from a team as code owners December 19, 2022 18:32
@MCele MCele force-pushed the MONIT-51 branch 3 times, most recently from 9d8b249 to 00459ff Compare July 26, 2023 13:50
@silviroa
Copy link
Contributor

silviroa commented Sep 5, 2023

USUARIO: mchiappe
BUILD NUMBER: 9557
CYPRESS RUN: 8680
TEST START: 2023-09-05T14:49:12.906Z
TOTAL: 388
SUCCESS: 381
FAIL: 6
SKIPPED: 1

@silviroa
Copy link
Contributor

silviroa commented Sep 5, 2023

USUARIO: mchiappe
BUILD NUMBER: 9563
CYPRESS RUN: 8686
TEST START: 2023-09-05T18:26:40.345Z
TOTAL: 372
SUCCESS: 363
FAIL: 8
SKIPPED: 1

Copy link
Contributor

@maring0019 maring0019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizar los cambios solicitados en el código.

@@ -51,10 +50,11 @@ export class ConceptosTurneablesComponent implements OnInit, OnDestroy {
if (conceptID || term) {
this.loading = true;
this.timeoutHandle = window.setTimeout(() => {
const termino = this.term;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quitar esta constante ya que no se está usando.

@@ -29,15 +33,30 @@ export class NuevoConceptoTurneableComponent implements OnInit {
nominalizada = false;
auditable = false;
loading = false;
showAlert = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quitar esta variable ya que no se está usando.

@maring0019 maring0019 added the changes requested Se solicitaron cambios label Sep 14, 2023
@ma7payne ma7payne force-pushed the MONIT-51 branch 2 times, most recently from 06e96b5 to 04fb9d4 Compare October 2, 2023 18:47
@ma7payne
Copy link
Contributor Author

ma7payne commented Oct 2, 2023

const termino = this.term;

Listo los cambios solicitados!

@ma7payne ma7payne added changes done Se realizaron los cambios pedidos. and removed changes requested Se solicitaron cambios labels Oct 2, 2023
@silviroa
Copy link
Contributor

silviroa commented Oct 3, 2023

USUARIO: mchiappe
BUILD NUMBER: 9722
CYPRESS RUN: 8830
TEST START: 2023-10-03T12:38:35.025Z
TOTAL: 403
SUCCESS: 401
FAIL: 0
SKIPPED: 2

@silviroa silviroa added test ok and removed test fail labels Oct 3, 2023
@maring0019 maring0019 self-requested a review October 4, 2023 16:53
@silviroa silviroa merged commit 276a27c into master Mar 6, 2024
1 check passed
@silviroa silviroa deleted the MONIT-51 branch March 6, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes done Se realizaron los cambios pedidos. prioritario test ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants