Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plex-select): permite crear items on demand #289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

liquid36
Copy link
Contributor

Permite seleccionar "crear" un items si no se encuentra en el listado.

@liquid36 liquid36 requested a review from a team as a code owner June 10, 2021 14:58
@liquid36 liquid36 requested review from condorpiedra and plammel and removed request for a team June 10, 2021 14:58
};
this.data.push(n);
return n;
}),
// dropdownParent: 'body',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Código comentado detected diría @martinebucarey

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@andrrrl andrrrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está buenísima la funcionalidad @liquid36!
Sólo me pasó lo que ve en el gif adjunto (no puedo usar el item agregado hasta que borro el input con el botón clear)
plex-select-add
Quizá se pueda hacer un ejemplo con una breve explicación de su uso.

@andrrrl andrrrl self-requested a review June 23, 2021 11:36
Copy link
Contributor

@andrrrl andrrrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@andrrrl
Copy link
Contributor

andrrrl commented Sep 1, 2021

No sé si alguien más podrá ver este PR. Quizá @JSantarelli y hay que rebasear

@andrrrl
Copy link
Contributor

andrrrl commented Oct 7, 2021

un rebasito y sale che!

@andrrrl
Copy link
Contributor

andrrrl commented Dec 1, 2021

Un rebasito y sale @liquid36!

@juuliotero
Copy link
Contributor

https://www.loom.com/share/4b34e1e09bb44350b7624c6b969dfbab

Si yo sumo al listado una palabra, y después quiero agregar otra que esté incluida en la primera, no me deja guardarla ya que me muestra esa opción.

Por ejemplo, primero sumo brasilia, y después quiero agregar brasil.

@AgosLizzi AgosLizzi requested review from ma7payne and AgosLizzi and removed request for condorpiedra and plammel May 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants