Build failure on windows py3.6

[fuhuifang]

Please find the logs below. With pywinpty 2.0.3, the build is broken. It used to work properly with pywinpty 2.0.2. Do you still support py3.6?

2022-03-03T00:23:12.9260551Z Building wheels for collected packages: pywinpty
2022-03-03T00:23:12.9285300Z   Building wheel for pywinpty (pyproject.toml): started
2022-03-03T00:24:52.8965769Z   Building wheel for pywinpty (pyproject.toml): still running...
2022-03-03T00:25:30.2715370Z   ERROR: Command errored out with exit status 1:
2022-03-03T00:25:30.2716555Z    command: 'c:\hostedtoolcache\windows\python\3.6.8\x64\python.exe' 'c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py' build_wheel 'C:\Users\RUNNER~1\AppData\Local\Temp\tmpclx526il'
2022-03-03T00:25:30.2717537Z        cwd: C:\Users\RUNNER~1\AppData\Local\Temp\pip-install-_lkb9kuf\pywinpty_8d545f64fb2b49e8aa6c7f7620e500ec
2022-03-03T00:25:30.2718130Z   Complete output (45 lines):
2022-03-03T00:25:30.2718654Z   Running `maturin pep517 build-wheel -i c:\hostedtoolcache\windows\python\3.6.8\x64\python.exe`
2022-03-03T00:25:30.2719305Z      Compiling libc v0.2.119
2022-03-03T00:25:30.2719642Z      Compiling pyo3-build-config v0.16.0
2022-03-03T00:25:30.2719998Z      Compiling proc-macro2 v1.0.36
2022-03-03T00:25:30.2720302Z      Compiling once_cell v1.9.0
2022-03-03T00:25:30.2720550Z      Compiling windows_x86_64_msvc v0.29.0
2022-03-03T00:25:30.2720901Z      Compiling unicode-xid v0.2.2
2022-03-03T00:25:30.2721141Z      Compiling autocfg v1.1.0
2022-03-03T00:25:30.2721386Z      Compiling syn v1.0.86
2022-03-03T00:25:30.2721636Z      Compiling winapi v0.3.9
2022-03-03T00:25:30.2721859Z      Compiling lazy_static v1.4.0
2022-03-03T00:25:30.2722131Z      Compiling parking_lot_core v0.8.5
2022-03-03T00:25:30.2722447Z      Compiling cfg-if v1.0.0
2022-03-03T00:25:30.2722684Z      Compiling either v1.6.1
2022-03-03T00:25:30.2722959Z      Compiling smallvec v1.8.0
2022-03-03T00:25:30.2723844Z      Compiling scopeguard v1.1.0
2022-03-03T00:25:30.2724144Z      Compiling unindent v0.1.8
2022-03-03T00:25:30.2724424Z      Compiling bitflags v1.3.2
2022-03-03T00:25:30.2724739Z      Compiling num-traits v0.2.14
2022-03-03T00:25:30.2725248Z      Compiling instant v0.1.12
2022-03-03T00:25:30.2725528Z      Compiling lock_api v0.4.6
2022-03-03T00:25:30.2725760Z      Compiling indoc v1.0.4
2022-03-03T00:25:30.2726181Z      Compiling which v4.2.4
2022-03-03T00:25:30.2726517Z      Compiling pyo3-ffi v0.16.0
2022-03-03T00:25:30.2726754Z      Compiling pyo3 v0.16.0
2022-03-03T00:25:30.2727015Z      Compiling quote v1.0.15
2022-03-03T00:25:30.2727241Z      Compiling windows v0.29.0
2022-03-03T00:25:30.2727936Z   error: failed to run custom build command for `pyo3-ffi v0.16.0`
2022-03-03T00:25:30.2728199Z   
2022-03-03T00:25:30.2728412Z   Caused by:
2022-03-03T00:25:30.2729142Z     process didn't exit successfully: `C:\Users\RUNNER~1\AppData\Local\Temp\pip-install-_lkb9kuf\pywinpty_8d545f64fb2b49e8aa6c7f7620e500ec\target\release\build\pyo3-ffi-18ee252067888828\build-script-build` (exit code: 1)
2022-03-03T00:25:30.2729696Z     --- stdout
2022-03-03T00:25:30.2730034Z     cargo:rerun-if-env-changed=PYO3_PRINT_CONFIG
2022-03-03T00:25:30.2730315Z   
2022-03-03T00:25:30.2730580Z     --- stderr
2022-03-03T00:25:30.2731019Z     error: the configured Python interpreter version (3.6) is lower than PyO3's minimum supported version (3.7)
2022-03-03T00:25:30.2731445Z   warning: build failed, waiting for other jobs to finish...
2022-03-03T00:25:30.2731745Z   error: build failed
2022-03-03T00:25:30.2741572Z   💥 maturin failed
2022-03-03T00:25:30.2741957Z     Caused by: Failed to build a native library through cargo
2022-03-03T00:25:30.2742615Z     Caused by: Cargo build finished with "exit code: 101": `cargo rustc --message-format json --manifest-path Cargo.toml --release --lib --`
2022-03-03T00:25:30.2751255Z   �\x8d� Building a mixed python/rust project
2022-03-03T00:25:30.2751719Z   🔗 Found pyo3 bindings
2022-03-03T00:25:30.2752187Z   �\x90\x8d Found CPython 3.6 at c:\hostedtoolcache\windows\python\3.6.8\x64\python.exe
2022-03-03T00:25:30.2752825Z   Error: command ['maturin', 'pep517', 'build-wheel', '-i', 'c:\\hostedtoolcache\\windows\\python\\3.6.8\\x64\\python.exe'] returned non-zero exit status 1
2022-03-03T00:25:30.2753346Z   ----------------------------------------
2022-03-03T00:25:30.2753661Z   ERROR: Failed building wheel for pywinpty
2022-03-03T00:25:30.2754096Z   Building wheel for pywinpty (pyproject.toml): finished with status 'error'
2022-03-03T00:25:30.2755044Z ERROR: Could not build wheels for pywinpty, which is required to install pyproject.toml-based projects
2022-03-03T00:25:30.2755420Z Failed to build pywinpty
2022-03-03T00:25:36.1125801Z ##[error]Process completed with exit code 1.
2022-03-03T00:25:36.1278285Z ##[group]Run python -m pytest tests/tests_compliant_logging --cov --junitxml=test-logging-result.xml --cov-fail-under=80
2022-03-03T00:25:36.1279071Z �[36;1mpython -m pytest tests/tests_compliant_logging --cov --junitxml=test-logging-result.xml --cov-fail-under=80�[0m
2022-03-03T00:25:36.1318458Z shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
2022-03-03T00:25:36.1318737Z env:
2022-03-03T00:25:36.1319055Z   pythonLocation: C:\hostedtoolcache\windows\Python\3.6.8\x64
2022-03-03T00:25:36.1319369Z ##[endgroup]
2022-03-03T00:25:36.5017293Z C:\hostedtoolcache\windows\Python\3.6.8\x64\python.exe: No module named pytest
2022-03-03T00:25:36.6992333Z ##[error]Process completed with exit code 1.
2022-03-03T00:25:36.7184698Z Post job cleanup.
2022-03-03T00:25:38.7474347Z [command]"C:\Program Files\Git\bin\git.exe" version
2022-03-03T00:25:38.7670761Z git version 2.35.1.windows.2
2022-03-03T00:25:38.7724491Z [command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
2022-03-03T00:25:38.7936446Z [command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2022-03-03T00:25:39.2600130Z [command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-03-03T00:25:39.2779331Z http.https://github.com/.extraheader
2022-03-03T00:25:39.2810981Z [command]"C:\Program Files\Git\bin\git.exe" config --local --unset-all http.https://github.com/.extraheader
2022-03-03T00:25:39.3019433Z [command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2022-03-03T00:25:39.7907645Z Cleaning up orphan processes

[andfoy]

Hi @fuhuifang, thanks for reaching out, by looking at the logs, it seems that the build error is due to PyO3 rather than of pywinpty. By looking at PyO3 changelog, they removed Python 3.6 support on version 0.16.0: PyO3/pyo3#2006

We definitely need to update our constraints on https://github.com/spyder-ide/pywinpty/blob/5e5fd2ab75efb21f2c32bf80fc8a43a29931f707/pyproject.toml#L3