Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT-145462: HTTP status code check in cpan is too inclusive #166

Open
briandfoy opened this issue Dec 7, 2022 · 0 comments
Open

RT-145462: HTTP status code check in cpan is too inclusive #166

briandfoy opened this issue Dec 7, 2022 · 0 comments

Comments

@briandfoy
Copy link
Contributor

I'm transferring and splitting up some issues reported in App::Cpan many problems, multiple fixes.

In App::Cpan::getfile, there is this overly inclusive line:

last if( 200 <= $status_code and $status_code <= 300 );

It should not include 300.

However, cpan(1) should also delegate the downloading to CPAN.pm perhaps (#163).

Patch provided by "eponymous alias" eponymousalias@yahoo.com in the RT ticket
App.Cpan.patch.txt
briandfoy added a commit to briandfoy/cpanpm that referenced this issue Dec 8, 2022
@briandfoy @nameless-user
andk#166 don't include HTTP status 300 when looking for 2xx
039111a 
Co-authored-by: "eponymous alias" <eponymousalias@yahoo.com>
@briandfoy briandfoy mentioned this issue Dec 8, 2022
Open
briandfoy added a commit to briandfoy/cpanpm that referenced this issue Dec 8, 2022
@briandfoy
Don't include 300 status in bounds andk#166
678a242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briandfoy