Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-f Makefile" to initial "make" (no args). Set PERL env var in "make test" and "make" #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rocky
Copy link

@rocky rocky commented Jul 4, 2016

I tried also adding the same "-f Makefile" to "make install" but a test fails:

$ blib/script/cpan -j t/97-lib_cpan1/CPAN/Config.pm Local::Make::Fails
Loading internal null logger. Install Log::Log4perl for logging messages
CPAN: Storable loaded ok (v2.53)
Reading '/src/external-vcs/github/rocky/cpanpm/cpan-home/Metadata'
Warning: Found only 11 objects in /src/external-vcs/github/rocky/cpanpm/cpan-home/Metadata
CPAN: LWP::UserAgent loaded ok (v6.13)
CPAN: Time::HiRes loaded ok (v1.9726)
CPAN: URI::URL loaded ok (v5.04)
Reading '/src/external-vcs/github/rocky/cpanpm/t/97-cpan1-test-mirror/authors/01mailrc.txt.gz'
CPAN: File::Which loaded ok (v1.19)
CPAN: Compress::Zlib loaded ok (v2.068)
............................................................................DONE
Reading '/src/external-vcs/github/rocky/cpanpm/t/97-cpan1-test-mirror/modules/02packages.details.txt'
  Database was generated on Tue, 27 Jan 2009 19:26:52 GMT
Warning: This index file is 2714 days old.
  Please check the host you chose as your CPAN mirror for staleness.
  I'll continue but problems seem likely to happen.�
............................................................................DONE
Reading '/src/external-vcs/github/rocky/cpanpm/t/97-cpan1-test-mirror/modules/03modlist.data.gz'
DONE
Writing /src/external-vcs/github/rocky/cpanpm/cpan-home/Metadata
Running install for module 'Local::Make::Fails'
CPAN: Digest::SHA loaded ok (v5.95)
Checksum for /src/external-vcs/github/rocky/cpanpm/t/97-cpan1-test-mirror/authors/id/B/BU/BUSTER/Local-Make-Fails.tgz ok
CPAN: Archive::Tar loaded ok (v2.04)
Local-Make-Fails/
Local-Make-Fails/.gitignore
Local-Make-Fails/.releaserc
Local-Make-Fails/Makefile.PL
Local-Make-Fails/MANIFEST
'YAML' not installed, will not store persistent state
CPAN: CPAN::Meta::Requirements loaded ok (v2.132)
CPAN: CPAN::Meta loaded ok (v2.150001)
Configuring B/BU/BUSTER/Local-Make-Fails.tgz with Makefile.PL
I didn't work. Too bad for you! at Makefile.PL line 5.
Warning: No success on command[/home/rocky/perl5/perlbrew/perls/perl-5.22.0/bin/perl Makefile.PL INSTALL_BASE=/src/external-vcs/github/rocky/cpanpm/cpan-home]
  BUSTER/Local-Make-Fails.tgz
  /home/rocky/perl5/perlbrew/perls/perl-5.22.0/bin/perl Makefile.PL INSTALL_BASE=/src/external-vcs/github/rocky/cpanpm/cpan-home -- NOT OK

See also discussion in cpantesters.

Rocky Bernstein added 2 commits July 4, 2016 08:36
ExtUtils::MakeMaker writes a file called Makefile. Explicitly use
that since GNU make can default to another name, e.g. GNUMakefile.

Notes:

* -f is in the POSIX spec for make.
* This doesn't happen if a custom make command is used,
  or if Module::Build's "Build" script is run

Also
@andk
Copy link
Owner

andk commented Jul 5, 2016

The request is missing a motivation section that explains what this pull request is trying to achieve which cannot be achieved otherwise. And it seems to violate the DRY principle, so it would help a lot if it could explain why such a violation would seem justified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants