remove unused tests, fix broken tests #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspier
approved these changes
May 11, 2024
|
All the tests worked for me yesterday. Why are they broken now? |
This test relied on Apache. Apache is long gone. So this test is long dead.
These tests were added a zillion years ago, but have been supplanted by the t/mldistwatch-* tests. Removing these removes our dependency on FITesque, which has broken in the past.
Putting aside whether this test is ever going to be valuable, it was straight-up broken. With no arguments given to all_critic_ok, it only ran the tests on blib, which has a single nearly empty file in it. Now we will test more of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.