Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added buffers for http postdata #230

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Conversation

LFriede
Copy link
Contributor

@LFriede LFriede commented Dec 3, 2017

Hi, this patch makes it possible to add a Duktape.Buffer as postdata. This is important for application/x-amf requests. I'll post a working example here in a few days when it's ready.

Greetings =)

@LFriede
Copy link
Contributor Author

LFriede commented Dec 4, 2017

The promised example in a new working plugin: https://github.com/LFriede/movian-dmax

@andoma
Copy link
Owner

andoma commented Jan 30, 2018

Ok, looks good I suppose. The only thing that I'm not sure about is setting the content-type to text/plain. Wouldn't it be better with application/octet-stream or something?

@Invictaz
Copy link

@andoma Can you fix the Android build script please?

@LFriede
Copy link
Contributor Author

LFriede commented Jan 31, 2018

@andoma Ah, sure, you're right. I didn't really noticed it because in my tests i had it set manually most of the time, sorry. I'll push a change later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants