Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle manually modified PR description #738

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

andrcuns
Copy link
Owner

@andrcuns andrcuns commented Jun 8, 2024

Correctly handle edited pr description/comment that can update how newline character is set


Test Report

allure-report-publisher generated test report!

rspec: ✅ test report for 040067e5

+----------------------------------------------------------------+
|                       behaviors summary                        |
+-----------+--------+--------+---------+-------+-------+--------+
|           | passed | failed | skipped | flaky | total | result |
+-----------+--------+--------+---------+-------+-------+--------+
| commands  | 132    | 0      | 0       | 0     | 132   ||
| providers | 92     | 0      | 0       | 0     | 92    ||
| helpers   | 172    | 0      | 0       | 0     | 172   ||
| generator | 12     | 0      | 0       | 0     | 12    ||
| cli       | 4      | 0      | 0       | 0     | 4     ||
| uploaders | 76     | 0      | 0       | 0     | 76    ||
+-----------+--------+--------+---------+-------+-------+--------+
| Total     | 488    | 0      | 0       | 0     | 488   ||
+-----------+--------+--------+---------+-------+-------+--------+

Copy link

codeclimate bot commented Jun 8, 2024

Code Climate has analyzed commit 040067e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.9% (0.0% change).

View more on Code Climate.

@andrcuns andrcuns changed the title Remove string modify when adding separator Correctly handle manually modified PR description Jun 8, 2024
@andrcuns andrcuns force-pushed the fix-incorrect-updated-match branch 5 times, most recently from 2fe9db7 to d621339 Compare June 8, 2024 10:39
@andrcuns andrcuns force-pushed the fix-incorrect-updated-match branch from eb299fa to 7aae056 Compare June 8, 2024 10:56
@andrcuns andrcuns force-pushed the fix-incorrect-updated-match branch from 3380da3 to 040067e Compare June 8, 2024 11:31
@andrcuns andrcuns added the bug Something isn't working label Jun 8, 2024
@andrcuns andrcuns merged commit d53a0e7 into main Jun 8, 2024
10 checks passed
@andrcuns andrcuns deleted the fix-incorrect-updated-match branch June 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant