[bug] assure format is a symbol #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the great gem 👍 Best regards |
skyporter
added a commit
to digITpro/catima
that referenced
this pull request
Nov 18, 2020
|
Spent quite a while before finding this PR :) Thanks! |
lucaguindani
added a commit
to catima/catima
that referenced
this pull request
Jan 6, 2021
* remove_capistrano * update_rails_ruby_gem * update_rails_ruby_gem * - namming fix - remove not useful .keep files - fix deprecation warning (`render template: XX`) * fix error when rendering panoramic template (andreapavoni/panoramic#27) * update panoramic gem to use a fork with a "fixed" master * fix class naming * fix assets loading with sprockets 4 (rails/sprockets-rails#328) * Rollback changing case of HTML to Html. Fix zeitwerk error by adding HTML and SQL words into `ActiveSupport::Inflector` acronym. * - active navbar item for custom menu too * init BS update * init BS update * improve login form * - rollback btn-sm to btn-xs and created dedicated class for this size of btn - styling btn secondary * nav dropdown on the right * fix badge color * form inline margin * input with btn * - fix form help + error (don't reduce size) * - fix translated field "locale label" on input group append * fix dropdown items * fix clear btn on input search * format blockquote * fix navtabs * media-heading doesn't exists on bs4 * fix h4 style * fix badge color * fix summernote editor * fix all nav-tabs dom (and fix height) * fix all nav-tabs dom (and fix height) * cleanup bootstrap (remove BS from yarn in favor of gem version) * cleanup bootstrap (remove BS from yarn in favor of gem version) * fix thumbnails * fix dropdown position * smaller table padding * fix popover * fix summernote editor * typo * Fix form validation error on reference fields * remove_capistrano * try using last node version on travis cli * change default style for active navbar item * remove not used BootstrapForm override * downgrade ruby version * set version to all gemfile * update to rails 6.1 * remove mini-racer gem + lock ruby gem version * fix gemfile * fixes for rails 6.1 * fixes for rails 6.1 * update font awesome rails * bundle 2.1.4 * update gemfile with catima/panoramic Co-authored-by: Manuel Wegria <abstract.s33d@gmail.com> Co-authored-by: Luca Guindani <luca.guindani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran in to an issue when using Panoramic with Rails6 and Ruby 2.7.0. The error is caused by
Mime[record.format]returning an object instead ofto_sym. I have not investigated what version permutation introduced the change.I've created an example project to reproduce the error: https://github.com/vandux/panoramic_error