Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support late apperances of routers #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nielslyngsoe
Copy link

@nielslyngsoe nielslyngsoe commented Mar 2, 2023

This PR enables sub router-slots to render themself.

In the current version of code a sub router, is only triggered to render by the parent routers initiative.

This PR makes: a router, with no match, try to do the rendering on its connectedCallback. Making late appeared router-slots work.

@nielslyngsoe
Copy link
Author

Hi @andreasbm

We would love to contribute to your package, but I see no activity at this moment.
Therefore we have chosen to close our Fork and continue our improvements for this package elsewhere.

If you return to maintaining this package, then let me know and I will open up PRs with the improvements that we have made.

Thanks for the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant