Fixed #205: Make lambdas as in class initializer work. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambdas as an in class initializer cause a `LambdaExpr` to occur in a `CXXConstructorDecl`s initializer list. This causes the lambda to be placed at a wrong location. It also triggers a behaviour where the `LambdaExpr` occurs twice. Once in the in class initializer as written and later in the `CXXConstructorDecl`. The first one cause a crash due to a `nullptr` access. This patch filters these lambdas out.
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 95.94% 95.95% +<.01%
==========================================
Files 29 29
Lines 2419 2424 +5
==========================================
+ Hits 2321 2326 +5
Misses 98 98
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambdas as an in class initializer cause a
LambdaExprto occur in aCXXConstructorDecls initializer list. This causes the lambda to beplaced at a wrong location.
It also triggers a behaviour where the
LambdaExproccurs twice. Oncein the in class initializer as written and later in the
CXXConstructorDecl.The first one cause a crash due to a
nullptraccess. This patchfilters these lambdas out.