Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncWrap init hook threw #19

Closed
julien-f opened this issue Jan 4, 2016 · 7 comments
Closed

AsyncWrap init hook threw #19

julien-f opened this issue Jan 4, 2016 · 7 comments

Comments

@julien-f
Copy link

julien-f commented Jan 4, 2016

Sometimes I get the error:

FATAL ERROR: node::AsyncWrap::AsyncWrap init hook threw
Aborted

Node v4.2.4 & trace v2.2.0.

@AndreasMadsen
Copy link
Owner

Try using node 5.3.0 there are some required internal features that node 4.2.4 doesn't have. However I have been promised that they will land in version 4.2.5

@julien-f
Copy link
Author

julien-f commented Jan 4, 2016

You should:

  1. express this requirement in package.json in the engines.node
  2. maybe even detect this at module startup and throw, because currently there is no way to handle this error and to fail gracefully (i.e. continue without trace).

@AndreasMadsen
Copy link
Owner

I'm not aware of a syntax that can set independent node version requirements for both v4 and v5. How does that look?

In any case the commits have already landed in v4-staging, so it is a very temporary issue: nodejs/node#3461 (comment)

@AndreasMadsen AndreasMadsen reopened this Jan 4, 2016
@julien-f
Copy link
Author

julien-f commented Jan 4, 2016

node: '^4.2.5 || ^5.3' should work.

What about code already using trace but before 4.2.5?
Currently the program aborts and it is not handled by a try-catch

@AndreasMadsen
Copy link
Owner

They should not upgrade to 2.2.x

@AndreasMadsen
Copy link
Owner

I guess semver was violated to that regard, I'm sorry about that. It is hard to keep track of when trace uses node internal API.

@AndreasMadsen
Copy link
Owner

I have published:

  • 2.2.1 with a better engines field that supports ^5.3
  • 2.0.2 with a better engines field that supports ^4.0

2.0.2 unfortunately don't have a fix for #17, that is not possible without the new features.

Also, I don't plan to continue doing legacy updates. But hopefully it shouldn't be necessary when 4.2.5 gets released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants