Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Status.isPinned a non-null value #220

Merged
merged 1 commit into from
May 30, 2023

Conversation

bocops
Copy link
Collaborator

@bocops bocops commented May 30, 2023

See #192 for discussion of this change. Resolves "issue 1" of that discussion, other issue still open.

See andregasser#192 for discussion of this change. Resolves "issue 1" of that discussion, other issue still open.
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #220 (e499006) into master (2e79e0c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #220   +/-   ##
=========================================
  Coverage     45.50%   45.50%           
  Complexity      280      280           
=========================================
  Files            83       83           
  Lines          2481     2481           
  Branches        133      133           
=========================================
  Hits           1129     1129           
  Misses         1298     1298           
  Partials         54       54           
Impacted Files Coverage Δ
...rc/main/kotlin/social/bigbone/api/entity/Status.kt 100.00% <100.00%> (ø)

Copy link
Owner

@andregasser andregasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocops bocops merged commit ff91c3f into andregasser:master May 30, 2023
@bocops bocops deleted the 192_non_null_isPinned branch May 30, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants