Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversations API #235

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add conversations API #235

merged 3 commits into from
Jul 18, 2023

Conversation

andregasser
Copy link
Owner

@andregasser andregasser linked an issue Jul 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #235 (0b742c6) into master (78d11a7) will increase coverage by 0.00%.
The diff coverage is 47.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     47.43%   47.44%           
- Complexity      298      307    +9     
=========================================
  Files            87       90    +3     
  Lines          2650     2698   +48     
  Branches        146      146           
=========================================
+ Hits           1257     1280   +23     
- Misses         1337     1362   +25     
  Partials         56       56           
Impacted Files Coverage Δ
.../kotlin/social/bigbone/rx/RxConversationMethods.kt 0.00% <0.00%> (ø)
...n/social/bigbone/api/method/ConversationMethods.kt 92.30% <92.30%> (ø)
...e/src/main/kotlin/social/bigbone/MastodonClient.kt 31.86% <100.00%> (+0.25%) ⬆️
...n/kotlin/social/bigbone/api/entity/Conversation.kt 100.00% <100.00%> (ø)

Copy link
Collaborator

@bocops bocops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some differences in entity definition vs. what we're doing elsewhere.

Additionally, one difference in the delete method, although this way could be preferable to what we're currently doing elsewhere - not completely sure about that.

@andregasser andregasser requested a review from bocops July 17, 2023 20:43
Copy link
Collaborator

@bocops bocops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@andregasser andregasser merged commit e2e396f into master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conversation endpoints
2 participants