-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversations API #235
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage 47.43% 47.44%
- Complexity 298 307 +9
=========================================
Files 87 90 +3
Lines 2650 2698 +48
Branches 146 146
=========================================
+ Hits 1257 1280 +23
- Misses 1337 1362 +25
Partials 56 56
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some differences in entity definition vs. what we're doing elsewhere.
Additionally, one difference in the delete method, although this way could be preferable to what we're currently doing elsewhere - not completely sure about that.
bigbone/src/main/kotlin/social/bigbone/api/entity/Conversation.kt
Outdated
Show resolved
Hide resolved
bigbone/src/main/kotlin/social/bigbone/api/entity/Conversation.kt
Outdated
Show resolved
Hide resolved
bigbone/src/main/kotlin/social/bigbone/api/entity/Conversation.kt
Outdated
Show resolved
Hide resolved
bigbone/src/main/kotlin/social/bigbone/api/method/ConversationMethods.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
https://docs.joinmastodon.org/methods/conversations/
Closes #196