Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 changes #5

Merged
merged 7 commits into from
Dec 16, 2015
Merged

PHP 7 changes #5

merged 7 commits into from
Dec 16, 2015

Conversation

Danack
Copy link
Contributor

@Danack Danack commented Mar 29, 2015

Hi,

PHP 7 is arriving later this year. I got a little bored and decided to upgrade this extension to work with PHP 7 and also setup Travis for testing purposes why not.

The test pass, all 4 of them; I don't actually use Bloomy in production so it might be a good idea for someone who does to test the extension both in 5.x and 7.

@andreiz
Copy link
Owner

andreiz commented Apr 3, 2015

Hi, I need a bit of time to review this. Should be able to merge later early next week.

@Danack
Copy link
Contributor Author

Danack commented Apr 3, 2015

fyi there's about 6 months until PHP 7 is meant to be released, so it's not like there's a huge rush.

@deeky666
Copy link

@andreiz any news on this? Would be nice to have PHP 7 support now that it's released.

@Danack
Copy link
Contributor Author

Danack commented Dec 14, 2015

@deeky666 have you tried the code by compiling it from source? e.g. with:

phpize
./configure
make install

and then put extension=extension=bloomy.so in the appropriate ini file.

@deeky666
Copy link

@Danack not yet. Thought this PR would be mandatory for bloomy to work with PHP 7, no? Sure I can merge manually etc., just wanted to ask for updates on when it's going to be available in master...

andreiz added a commit that referenced this pull request Dec 16, 2015
@andreiz andreiz merged commit 27fe28e into andreiz:master Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants