-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7 changes #5
Conversation
…version depend memory managment
Hi, I need a bit of time to review this. Should be able to merge later early next week. |
fyi there's about 6 months until PHP 7 is meant to be released, so it's not like there's a huge rush. |
@andreiz any news on this? Would be nice to have PHP 7 support now that it's released. |
@deeky666 have you tried the code by compiling it from source? e.g. with:
and then put |
@Danack not yet. Thought this PR would be mandatory for bloomy to work with PHP 7, no? Sure I can merge manually etc., just wanted to ask for updates on when it's going to be available in master... |
Hi,
PHP 7 is arriving later this year. I got a little bored and decided to upgrade this extension to work with PHP 7 and also setup Travis for testing purposes why not.
The test pass, all 4 of them; I don't actually use Bloomy in production so it might be a good idea for someone who does to test the extension both in 5.x and 7.