Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve authentication methods #38

Merged
merged 1 commit into from
Apr 13, 2019
Merged

feat: Improve authentication methods #38

merged 1 commit into from
Apr 13, 2019

Conversation

andreroggeri
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Apr 12, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.9%) to 100.0% when pulling 38b9f91 on add-refresh-token-auth into 53e3956 on master.

@lucasrcezimbra
Copy link
Contributor

I think that if this PR is merged, major version should be increase, it will break the API because of the change in init.

@andreroggeri
Copy link
Owner Author

Agreed, the main idea of this PR is to extract the logic of the authentication to another method to:

  1. Keep the constructor lightweigth
  2. Add the possibility to the client handle the QRCode (For example, a Telegram bot that sends the QRCode so I can keep some part of the automation)
  3. Add a possibility to use the refresh token

One side note: I discovered that still possible to authenticate without the QRCode by using the refresh_token.

@andreroggeri andreroggeri changed the title feat: Improve authentication methods WIP feat: Improve authentication methods Apr 12, 2019
@andreroggeri andreroggeri changed the title WIP feat: Improve authentication methods feat: Improve authentication methods Apr 13, 2019
@andreroggeri andreroggeri merged commit c0d4a1b into master Apr 13, 2019
@andreroggeri andreroggeri deleted the add-refresh-token-auth branch April 13, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreroggeri @coveralls @lucasrcezimbra