Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payee/Payer Integration (iss3). #31

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Payee/Payer Integration (iss3). #31

merged 1 commit into from
Feb 10, 2018

Conversation

andrerwolff
Copy link
Owner

Payee table changed to have payee_type. In the future we might want to create another table for payer. Currently payers (deposits) use type = 1 and payees (withdrawals) use type = 2.
When you enter a deposit, it will display all payees where type = 1, and any created payee will have type 1. Entering a deposit will use type = 2.

@andrerwolff andrerwolff merged commit 0ee610f into master Feb 10, 2018
@andrerwolff andrerwolff mentioned this pull request Feb 10, 2018
@mharty3
Copy link
Collaborator

mharty3 commented Feb 10, 2018

Curious why we need to keep track of payee vs payer? Some will be both. Sometimes I pay you back for beer, and sometimes you pay me back. Do I then have two entries in this table for you where one is type=1 and one is type=2?

@andrerwolff
Copy link
Owner Author

I figured that like 90% of the time they will be separate. I would rather have a couple duplicate entries in the table then have to wade through a bunch of payees when I put in my income from work. I could be convinced though. I kept them separate to help when choosing in the transaction, it will only display the list of appropriate names. Idk though...

@andrerwolff andrerwolff deleted the iss3 branch February 13, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants