-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.4 #81
Merged
Merged
Release v1.4 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
… IPv4 Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Instruct printf in load_config to read lines as is, instead of trying to intrepet line contents as printf control characters. Fixes the odd "print Y" error Signed-off-by: Sami Olmari <sami@olmari.fi>
For some reason the load_config.sh nullifies whole line if there is `#` after the actual line, in the line, so for now move the instruction about `man date` elsewhere and leave actual date_format line to contain only actual data. Fixes date_fpormat string to be actually used if set up. Signed-off-by: Sami Olmari <sami@olmari.fi>
Signed-off-by: Sami Olmari <sami@olmari.fi>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Features/cleanup status - Fix bug when some commands are not found with which - Add information to getIP* and an explanation about regex - Move all status code into own print* functions - Add extra helper functions with common formatting to unify overall behavior - Prepare main function for separate logo and text printing - Wrap the script in a single function to avoid environment pollution - Extra comments on codingstyle - Fix "Y" error message when using config file - Clean up code comments - Prevent load_config from interpreting the configuration files - Wrap status.sh in a single function to avoid environment pollution - Other minor fixes
olmari
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…ible if install/uninstall specified when calling the installer Signed-off-by: Andres Gongora <andresgongora@uma.es>
Make the installer prompt the user about what to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which
command failed