Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.4 #81

Merged
merged 35 commits into from
Jun 7, 2019
Merged

Release v1.4 #81

merged 35 commits into from
Jun 7, 2019

Conversation

andresgongora
Copy link
Owner

  • Fix bug when some commands are not found with which
  • Date format is now configurable
  • Fix "Y" error message when using config file
  • Fix error messages on some distros when which command failed
  • Status.sh does no longer pollute the environment with stray functions or variables
  • Fix to load_config where the configuration might be interpreted as escape sequences
  • Improvements to installer
  • Other minor fixes
  • Overall code cleanup

andresgongora and others added 30 commits June 4, 2019 16:47
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
… IPv4

Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Instruct printf in load_config to read lines as is, instead of
trying to intrepet line contents as printf control characters.

Fixes the odd "print Y" error

Signed-off-by: Sami Olmari <sami@olmari.fi>
For some reason the load_config.sh nullifies whole line if there is
`#` after the actual line, in the line, so for now move the instruction
about `man date` elsewhere and leave actual date_format line to
contain only actual data.

Fixes date_fpormat string to be actually used if set up.

Signed-off-by: Sami Olmari <sami@olmari.fi>
olmari and others added 3 commits June 7, 2019 01:32
Signed-off-by: Sami Olmari <sami@olmari.fi>
Signed-off-by: Andres Gongora <andresgongora@uma.es>
Features/cleanup status

- Fix bug when some commands are not found with which
- Add information to getIP* and an explanation about regex
- Move all status code into own print* functions
- Add extra helper functions with common formatting to unify overall behavior
- Prepare main function for separate logo and text printing
- Wrap the script in a single function to avoid environment pollution
- Extra comments on codingstyle
- Fix "Y" error message when using config file
- Clean up code comments
- Prevent load_config from interpreting the configuration files
- Wrap status.sh in a single function to avoid environment pollution
- Other minor fixes
@andresgongora andresgongora requested a review from olmari June 7, 2019 07:15
@andresgongora andresgongora self-assigned this Jun 7, 2019
Copy link
Collaborator

@olmari olmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

…ible if install/uninstall specified when calling the installer

Signed-off-by: Andres Gongora <andresgongora@uma.es>
Make the installer prompt the user about what to do
@andresgongora andresgongora merged commit 27651b8 into master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants