-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider alternate icons #16
Comments
Going with straight colors might be nice: 🟢 : Faster And this makes sense I think: |
Ooo that is clean. Yea, I'm not a fan of the current 🔍 icon for unsure as it seems to imply there is some "inspecting" action I should take when in reality, most commits will likely not meaningfully impact perf. ⚪ seems to better fade blend in allow the faster or slower results to draw more attention. cc: @developit, @marvinhagemeister As the other two big users of these results, thoughts here? |
I'd prefer icons with a distinct contour compared to color bubbles. Otherwise people with a red/green eyesight issue won't be able to differentiate the two. |
I think I'm settling on the following updates. I like the ❔ cuz it blends it a little better with text being only black and white but is also a unique contour so we don't only rely on color to communicate info. Could also use ⚪ since the others remain ❌ and ✔ but I think I'm leaning to the question mark. Running status: ⏳ instead of ⏱ |
Sounds good to me! |
Hopping in a few years late to say icons that can be colored might be preferable to emojis as their color is entirely platform-dependent; the "heavy check", for example, is grey on iOS and on my Linux setup, where as on Android I've heard it's red? Super minor of course, just would be a nice-to-have. |
For running:
For unsure result:
The text was updated successfully, but these errors were encountered: