Fall back to source install only when binary URL is 404 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the install from a binary package fails it falls back to installing from source. Tthe only case where the fallback should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on various IO or permissions errors. Fixes #30
andrewkroh
force-pushed
the
source-install-on-404
branch
from
45d3b47
to
9de1350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the install from a binary package fails it falls back to installing from source. Tthe only case where the fallback
should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on
various IO or permissions errors.
Fixes #30