Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GVM_ARCH env var and --arch CLI flag #53

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix GVM_ARCH env var and --arch CLI flag #53

merged 1 commit into from
Aug 3, 2022

Conversation

andrewkroh
Copy link
Owner

The code is setting the GOOS value when it should have been setting GOARCH.

@andrewkroh
Fix GVM_ARCH env var and --arch CLI flag
f3bf9e6 
The code is setting the GOOS value when it should have been setting GOARCH.
@andrewkroh andrewkroh added the bug label Aug 3, 2022
@andrewkroh andrewkroh mentioned this pull request Aug 3, 2022
Closed
tsg
tsg approved these changes Aug 3, 2022
View reviewed changes
Copy link

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By chance I happen to still watch this repo, so why not approve a PR 😄

@andrewkroh
Copy link
Owner Author

Thanks @tsg ❤️

@andrewkroh andrewkroh merged commit 0f49d00 into main Aug 3, 2022
@andrewkroh andrewkroh deleted the fix-arch-flag branch August 3, 2022 19:19
@mdelapenya
Copy link

Thank you @andrewkroh for the quick fix and the explanation!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @mdelapenya @tsg