Add dockerfile #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayufan
suggested changes
Jul 13, 2017
Makefile
Outdated
| @@ -0,0 +1,9 @@ | |||
| dependencies: | |||
| go get github.com/digitalocean/godo | |||
ayufan
reviewed
Jul 13, 2017
Dockerfile
Outdated
| RUN apk add -U ca-certificates | ||
|
|
||
| COPY . . | ||
| RUN apk add --no-cache git make; \ |
There was a problem hiding this comment.
go get -v ./cmd/digitalocean_exporter
I believe that this should also compile and install in path,
There was a problem hiding this comment.
Yes, it does. And it allows us to not use Makefile. I'll update the PR.
|
Strange that Travis is failing here but not in general. Their docs state |
tmaczukin
force-pushed
the
add-dockerfile
branch
from
0ab330c
to
75d0c07
Compare
|
@andrewsomething It's green now. |
|
👍 Great! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes possible to use exporter as Docker container.