Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge anyone #47

Open
dblock opened this issue Apr 21, 2015 · 5 comments
Open

Challenge anyone #47

dblock opened this issue Apr 21, 2015 · 5 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Apr 21, 2015

I'd like to be able to challenge anyone, not a specific user. Currently this "problem" is solved by begging.

screen shot 2015-04-21 at 4 13 12 pm

@andrewvy
Copy link
Owner

I took a stab at this a while ago, but I think the flow could be better.

9bec877

@dblock
Copy link
Collaborator Author

dblock commented Apr 22, 2015

I think it should work like this: pongbot challenge singles (it can't be pongbot challenge singles anyone because someone could be named anyone :), which creates a Challenge without any challenged opponents, then when you pongbot accept you become either the opponent or a teammate for doubles. Codewise it means looking for one such open challenge when you accept.

@andrewvy
Copy link
Owner

That sounds good to me. I like the dual use of the challenge command.

pongbot challenge singles
pongbot challenge doubles

I think there should just only be one open challenge, it could get confusing. So joining one would just be whatever current open challenge there is. And then trying to create another open challenge would just remind you that there's one already.

I feel like an open challenge should expire over time though, just in case someone created one but no one joined ( 😢 ) and it got left overnight.

@dblock
Copy link
Collaborator Author

dblock commented Apr 22, 2015

👍

@dblock
Copy link
Collaborator Author

dblock commented Apr 22, 2015

I think generally there's no reason to have long lived challenges that aren't accepted, opened #53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants