-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed the colon for each dimension in len functions arguments. #47
Conversation
I'm happy to merge this one, but could you add a comment to the top of the file outlining the problem and why the colons should not be included. It would be a good idea to give an exact version of the compiler and, if you have it, a reference for the bug report to PGI. Out of interest, what happens for subsets of an array - e.g. |
Ok Thanks. |
Merging from your master branch onto my master branch isn't a problem. Assuming your local master is the same as your master on github you should be able to However, if your local master is ahead of your master on github it's probably easer to create a new branch and pull request from that. If you need to do this you should do is checkout your master branch ( |
…as making pgi compilers produce bugged code which tried to allocate huge amount of memory anytime that a str function was called with an array argument
Ok For PGI the bug is still present in latest community edition version 17.10. I don't have access to the more recent licensed versions, so I can't say if it has been fixed. I checked the issue disappears is you pass a slice of the whole array, but if you use ia(1:dim) then the result is wrong again. |
…selective preprocessor directive
I knew this reminded me of something. We put those colons in to work around a compiler bug in the intel compiler in 2012. See: 0894588! Even given the age I suspect there are still ifort 12 users out there so using the pre-compiler seems seems sensible. I'll merge this as is. This really makes me wish I had CI set up for intel and PGI. Both versions of the code run fine under gfortran. I suspect I can set something up with the PGI community edition. I may be able to do ifort too (waiting to see what our HPC support group discover about the small print of the licence). |
I don't know why but those colons were making pgi compiler produce bugged code which tried to allocate huge amount of memory anytime that a str function was called with an array argument.