Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Only run tests on API levels where they are supported. #116

Merged
merged 1 commit into from
Jan 27, 2018

Conversation

JakeWharton
Copy link
Contributor

@JakeWharton JakeWharton commented Jan 27, 2018

This also contains some fixes for problems found on older APIs:

  • equals is missing for PointF, RectF, etc.
  • TransitionManager.endTransition isn't available on 19
  • Bundle and PersistableBundle added support for types on various API levels.

For whatever reason the ShaderTest crashes on API 23 and 24. Everything else is good though:

Starting 235 tests on Nexus_4_API_15(AVD) - 4.0.4
Starting 260 tests on Nexus_4_API_17(AVD) - 4.2.2
Starting 289 tests on Nexus_4_API_19(AVD) - 4.4.2
Starting 300 tests on Nexus_4_API_21(AVD) - 5.0.2
Starting 304 tests on Nexus_4_API_23(AVD) - 6.0
Starting 304 tests on Nexus_4_API_24(AVD) - 7.0
Starting 370 tests on Nexus_4_API_26(AVD) - 8.0.0

androidx.graphics.ShaderTest > testTransform[Nexus_4_API_23(AVD) - 6.0] FAILED
Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Native crash''. Check device logcat for details
Tests on Nexus_4_API_23(AVD) - 6.0 failed: Instrumentation run failed due to 'Native crash'

androidx.graphics.ShaderTest > testTransform[Nexus_4_API_24(AVD) - 7.0] FAILED
Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.''. Check device logcat for details
Tests on Nexus_4_API_24(AVD) - 7.0 failed: Instrumentation run failed due to 'Process crashed.'

Closes #114.

This also contains some fixes for problems found on older APIs:
* equals is missing for PointF, RectF, etc.
* TransitionManager.endTransition isn't available on 19
* Bundle and PersistableBundle added support for types on various API levels.
@JakeWharton JakeWharton merged commit e820cc8 into master Jan 27, 2018
@JakeWharton JakeWharton deleted the jakew/sdk-suppress/2018-01-27 branch February 5, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests need to use @SdkSuppress(minSdkVersion=) to prevent running on old APIs.
2 participants