Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M1 Make #1546

Closed
Tracked by #1299
DanAlbert opened this issue Jul 26, 2021 · 1 comment
Closed
Tracked by #1299

M1 Make #1546

DanAlbert opened this issue Jul 26, 2021 · 1 comment
Labels
enhancement
Projects
r24 r23c

Comments

@DanAlbert
Copy link
Member

Subtask for #1299
@DanAlbert DanAlbert added this to Triaged in r23 via automation Jul 26, 2021
@DanAlbert DanAlbert added this to Triaged in r24 via automation Jul 26, 2021
@DanAlbert DanAlbert mentioned this issue Jul 26, 2021
Open
9 tasks
@DanAlbert DanAlbert removed this from Triaged in r23 Aug 13, 2021
@DanAlbert DanAlbert added this to Triaged in r23b via automation Aug 13, 2021
@rprichard rprichard removed this from Triaged in r23b Sep 23, 2021
@rprichard rprichard added this to Triaged in r23c Sep 23, 2021
@DanAlbert DanAlbert moved this from Triaged to Merged in r24 Nov 19, 2021
@DanAlbert DanAlbert moved this from Triaged to Needs cherry-pick in r23c Apr 21, 2022
@DanAlbert
Copy link
Member Author

Should be fixed in r23 build 8486889.

r23c automation moved this from Needs cherry-pick to Merged Apr 22, 2022
MaoHan001 pushed a commit to riscv-android-src/platform-ndk that referenced this issue Jun 22, 2022
@rprichard
Switch make to ndk.builds.CMakeModule
c1885df 
This change stops linking gnulib's fcntl on Windows, fixing --output-sync.

Bug: android/ndk#1492
Bug: android/ndk#1546
Change-Id: I8cd16eda2899451a6ae43ec1cf7008122746c576
(cherry picked from commit d5a5e29)
Merged-In: I8cd16eda2899451a6ae43ec1cf7008122746c576
MaoHan001 pushed a commit to riscv-android-src/platform-ndk that referenced this issue Jun 22, 2022
@rprichard
Switch make and shader-tools to macOS universal builds
a164f8e 
Test: checkbuild.py on macOS Big Sur with Xcode 12.5.1
Bug: android/ndk#1546
Bug: android/ndk#1577
Change-Id: I09e477c50c8e3eb927dc3a713278d290c5c213e5
(cherry picked from commit f9cbfd2)
Merged-In: I09e477c50c8e3eb927dc3a713278d290c5c213e5
MaoHan001 pushed a commit to riscv-android-src/platform-ndk that referenced this issue Jun 22, 2022
@DanAlbert
Add changelog notes for M1 shader-tools/make.
02fc3ef 
Bug: android/ndk#1546
Bug: android/ndk#1577
Test: None
Change-Id: Ib42b3644966ff691f45595d9e2bbe456b4a91c22
(cherry picked from commit 0d991cbe04d8afede6649dfa1584cba40b775664)
Merged-In: Ib42b3644966ff691f45595d9e2bbe456b4a91c22
rooteduniverse1003 pushed a commit to rooteduniverse1003/Android-ToolChain-Make that referenced this issue Nov 21, 2023
@rprichard
Build make using cmake+ninja
e357d1c 
For Windows, we need to avoid cross-compiling using the configure
script, because it will link with more gnulib modules than is
supported. gnulib's fcntl.c module breaks --output-sync (NDK bug 1492).
Instead, mimic build_w32.bat by:
 - building the same list of C files
 - copying the same gnulib headers
 - reusing the same config.h.W32.template file

For Darwin, the host-cpu-c-abi gnulib module breaks universal builds,
but it's easy to disable the module by editing config.h by hand
afterwards. (Removing that module from bootstrap.conf and rerunning
bootstrap might also be an option, but it changes a lot of stuff.)

I created CMakeLists.txt by translating Android.bp manually.

Bug: android/ndk#1492
Bug: android/ndk#1546
Change-Id: I367109233967ec6f0a1637b3ab262a234c93bc5b
(cherry picked from commit 487fc28)
Merged-In: I367109233967ec6f0a1637b3ab262a234c93bc5b
rooteduniverse1003 pushed a commit to rooteduniverse1003/Android-ToolChain-Make that referenced this issue Nov 21, 2023
@rprichard
Build make using cmake+ninja
97b3781 
For Windows, we need to avoid cross-compiling using the configure
script, because it will link with more gnulib modules than is
supported. gnulib's fcntl.c module breaks --output-sync (NDK bug 1492).
Instead, mimic build_w32.bat by:
 - building the same list of C files
 - copying the same gnulib headers
 - reusing the same config.h.W32.template file

For Darwin, the host-cpu-c-abi gnulib module breaks universal builds,
but it's easy to disable the module by editing config.h by hand
afterwards. (Removing that module from bootstrap.conf and rerunning
bootstrap might also be an option, but it changes a lot of stuff.)

I created CMakeLists.txt by translating Android.bp manually.

Bug: android/ndk#1492
Bug: android/ndk#1546
Change-Id: I367109233967ec6f0a1637b3ab262a234c93bc5b
(cherry picked from commit 487fc28)
Merged-In: I367109233967ec6f0a1637b3ab262a234c93bc5b
rooteduniverse1003 pushed a commit to rooteduniverse1003/Android-ToolChain-Make that referenced this issue Nov 21, 2023
@rprichard
Build make using cmake+ninja
f080a77 
For Windows, we need to avoid cross-compiling using the configure
script, because it will link with more gnulib modules than is
supported. gnulib's fcntl.c module breaks --output-sync (NDK bug 1492).
Instead, mimic build_w32.bat by:
 - building the same list of C files
 - copying the same gnulib headers
 - reusing the same config.h.W32.template file

For Darwin, the host-cpu-c-abi gnulib module breaks universal builds,
but it's easy to disable the module by editing config.h by hand
afterwards. (Removing that module from bootstrap.conf and rerunning
bootstrap might also be an option, but it changes a lot of stuff.)

I created CMakeLists.txt by translating Android.bp manually.

Bug: android/ndk#1492
Bug: android/ndk#1546
Change-Id: I367109233967ec6f0a1637b3ab262a234c93bc5b
(cherry picked from commit 487fc28)
Merged-In: I367109233967ec6f0a1637b3ab262a234c93bc5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
r23c
  
Merged
r24
  
Merged
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanAlbert