Empty search text is added in recent searches problem fix. #1223
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For empty query not add in recent query list.
...earch/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModel.kt
Outdated
Show resolved
Hide resolved
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
- Early return to do not call onSearchExplicitlyTriggered() Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
...earch/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModel.kt
Outdated
Show resolved
Hide resolved
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
…uery Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
dturner
reviewed
Mar 5, 2024
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Mar 5, 2024
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Mar 5, 2024
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Mar 5, 2024
...h/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Outdated
Show resolved
Hide resolved
dturner
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for doing this @Jaehwa-Noh, and for reviewing @SimonMarquis. Added some suggestions for test names.
…droid/feature/search/SearchViewModelTest.kt Change name to emptySearchText_isNotAddedTorecentSearches() Co-authored-by: Don Turner <dturner@users.noreply.github.com>
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
…uery() Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
…isEmptyQuery()" This reverts commit e4c1765.
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Empty search is added in recent searches. It was unpredictable behavior. I fixed it.
• Add if statement to prevent insert empty query.
• Add blank text prevent keyboard hide and search.
• Add test code.
Fixes #1222