Tweak the SearchScreen with empty search results #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thagikura
force-pushed
the
fix_news_resource_query
branch
from
878a928
to
b9ecaa8
Compare
- Display the recent searches - Tweak the styles to match the UI mock Add missing useFilterNewsIds argument to search for the NewsResources.
thagikura
force-pushed
the
fix_news_resource_query
branch
from
b9ecaa8
to
983831c
Compare
thagikura
changed the title
thagikura
changed the title
That is displayed when *Fts tables are not populated
mmoczkowski
approved these changes
Apr 24, 2023
...com/google/samples/apps/nowinandroid/core/data/repository/DefaultSearchContentsRepository.kt
Outdated
Show resolved
Hide resolved
...com/google/samples/apps/nowinandroid/core/testing/repository/TestSearchContentsRepository.kt
Show resolved
Hide resolved
...ure/search/src/main/java/com/google/samples/apps/nowinandroid/feature/search/SearchScreen.kt
Show resolved
Hide resolved
...ure/search/src/main/java/com/google/samples/apps/nowinandroid/feature/search/SearchScreen.kt
Outdated
Show resolved
Hide resolved
...ure/search/src/main/java/com/google/samples/apps/nowinandroid/feature/search/SearchScreen.kt
Outdated
Show resolved
Hide resolved
.../search/src/main/java/com/google/samples/apps/nowinandroid/feature/search/SearchViewModel.kt
Outdated
Show resolved
Hide resolved
thagikura
added a commit
that referenced
this pull request
Apr 25, 2023
Tweak the SearchScreen with empty search results. - Display the recent searches - Tweak the styles to match the UI mock - Use Text for each row in recent searches so that ripple effect is applied when it's clicked - Add missing useFilterNewsIds argument to search for the NewsResources. Also add SearchNotReadyBody that is displayed before the *Fts tables are populated which is triggered by WorkManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the SearchScreen with empty search results.
Also add SearchNotReadyBody that is displayed before the *Fts tables are populated which is triggered by WorkManager
Screenshot:
Search result is empty:
Search is not ready (*Fts tables hasn't been populated)
