Implement topics list/detail view for large screens #701

mmoczkowski · 2023-04-28T15:19:32Z

Compact		Expanded
topic not selected	topic selected	topic not selected	topic selected

alexvanyo

This is looking great @mmoczkowski !

I did see one crash when testing it out:

When running the app on a tablet, rotating the device back and forth while on the interests tab with no topic selected eventually results in a crash with a stacktrace like the following:

Stacktrace

2023-05-05 15:32:19.569  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  FATAL EXCEPTION: main
                                                                                                    Process: com.google.samples.apps.nowinandroid.demo.debug, PID: 5982
                                                                                                    java.lang.IllegalStateException: Unsupported concurrent change during composition. A state object was modified by composition as well as being modified outside composition.
                                                                                                    	at androidx.compose.runtime.Recomposer.applyAndCheck(Recomposer.kt:1127)
                                                                                                    	at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1460)
                                                                                                    	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:3952)
                                                                                                    	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:3952)
                                                                                                    	at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:519)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcomposeInto(SubcomposeLayout.kt:466)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:439)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:430)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:419)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope.subcompose(SubcomposeLayout.kt:740)
                                                                                                    	at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.measure-0kLqBqw(LazyLayoutMeasureScope.kt:118)
                                                                                                    	at androidx.compose.foundation.lazy.LazyMeasuredItemProvider.getAndMeasure-ZjPyQlc(LazyMeasuredItemProvider.kt:47)
                                                                                                    	at androidx.compose.foundation.lazy.LazyListMeasureKt.measureLazyList-QaF8Ofo(LazyListMeasure.kt:162)
                                                                                                    	at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke-0kLqBqw(LazyList.kt:299)
                                                                                                    	at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke(LazyList.kt:190)
                                                                                                    	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$1$2$1.invoke-0kLqBqw(LazyLayout.kt:71)
                                                                                                    	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$1$2$1.invoke(LazyLayout.kt:69)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:598)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.foundation.AndroidOverscrollKt$StretchOverscrollNonClippingLayer$2.invoke-3p2s80s(AndroidOverscroll.kt:578)
                                                                                                    	at androidx.compose.foundation.AndroidOverscrollKt$StretchOverscrollNonClippingLayer$2.invoke(AndroidOverscroll.kt:577)
                                                                                                    	at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:286)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.foundation.AndroidOverscrollKt$StretchOverscrollNonClippingLayer$1.invoke-3p2s80s(AndroidOverscroll.kt:562)
                                                                                                    	at androidx.compose.foundation.AndroidOverscrollKt$StretchOverscrollNonClippingLayer$1.invoke(AndroidOverscroll.kt:561)
                                                                                                    	at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:286)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:673)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.foundation.layout.PaddingModifier.measure-3p2s80s(Padding.kt:364)
                                                                                                    	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
2023-05-05 15:32:19.570  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnMeasurementHelper.measureWithoutPlacing-_EkL_-Y(RowColumnMeasurementHelper.kt:170)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnImplKt$rowColumnMeasurePolicy$1.measure-3p2s80s(RowColumnImpl.kt:70)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnMeasurementHelper.measureWithoutPlacing-_EkL_-Y(RowColumnMeasurementHelper.kt:170)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnImplKt$rowColumnMeasurePolicy$1.measure-3p2s80s(RowColumnImpl.kt:70)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
2023-05-05 15:32:19.571  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:115)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.ui.graphics.BlockGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:610)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:115)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
                                                                                                    	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
2023-05-05 15:32:19.572  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnMeasurementHelper.measureWithoutPlacing-_EkL_-Y(RowColumnMeasurementHelper.kt:112)
                                                                                                    	at androidx.compose.foundation.layout.RowColumnImplKt$rowColumnMeasurePolicy$1.measure-3p2s80s(RowColumnImpl.kt:70)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)
                                                                                                    	at androidx.compose.foundation.layout.InsetsPaddingModifier.measure-3p2s80s(WindowInsetsPadding.kt:171)
                                                                                                    	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.foundation.layout.PaddingValuesModifier.measure-3p2s80s(Padding.kt:417)
                                                                                                    	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
                                                                                                    	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
                                                                                                    	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
                                                                                                    	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1.invoke(Scaffold.kt:242)
2023-05-05 15:32:19.573  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1.invoke(Scaffold.kt:130)
                                                                                                    	at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                                                                                                    	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1$measure$1.placeChildren(SubcomposeLayout.kt:610)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:276)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:268)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutSnapshotReads$ui_release(OwnerSnapshotObserver.kt:77)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.layoutChildren(LayoutNodeLayoutDelegate.kt:268)
                                                                                                    	at androidx.compose.ui.node.LayoutNode.onNodePlaced$ui_release(LayoutNode.kt:934)
                                                                                                    	at androidx.compose.ui.node.InnerNodeCoordinator.placeAt-f8xVGno(InnerNodeCoordinator.kt:137)
                                                                                                    	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:445)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:451)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:445)
                                                                                                    	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2200)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
                                                                                                    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
                                                                                                    	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                                                                                                    	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutModifierSnapshotReads$ui_release(OwnerSnapshotObserver.kt:92)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-f8xVGno(LayoutNodeLayoutDelegate.kt:445)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.replace(LayoutNodeLayoutDelegate.kt:466)
                                                                                                    	at androidx.compose.ui.node.LayoutNode.replace$ui_release(LayoutNode.kt:822)
                                                                                                    	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:445)
                                                                                                    	at androidx.compose.ui.node.MeasureAndLayoutDelegate.access$remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:39)
                                                                                                    	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:330)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:778)
                                                                                                    	at androidx.compose.ui.node.Owner.measureAndLayout$default(Owner.kt:216)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:1008)
2023-05-05 15:32:19.575  5982-5982  AndroidRuntime          com....apps.nowinandroid.demo.debug  E  	at android.view.View.draw(View.java:23732)
                                                                                                    	at android.view.View.updateDisplayListIfDirty(View.java:22596)
                                                                                                    	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4523)
                                                                                                    	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4496)
                                                                                                    	at android.view.View.updateDisplayListIfDirty(View.java:22552)
                                                                                                    	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4523)
                                                                                                    	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4496)
                                                                                                    	at android.view.View.updateDisplayListIfDirty(View.java:22552)
                                                                                                    	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4523)
                                                                                                    	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4496)
                                                                                                    	at android.view.View.updateDisplayListIfDirty(View.java:22552)
                                                                                                    	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4523)
                                                                                                    	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4496)
                                                                                                    	at android.view.View.updateDisplayListIfDirty(View.java:22552)
                                                                                                    	at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:694)
                                                                                                    	at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:700)
                                                                                                    	at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:798)
                                                                                                    	at android.view.ViewRootImpl.draw(ViewRootImpl.java:4858)
                                                                                                    	at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4562)
                                                                                                    	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3745)
                                                                                                    	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2398)
                                                                                                    	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9393)
                                                                                                    	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1278)
                                                                                                    	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1286)
                                                                                                    	at android.view.Choreographer.doCallbacks(Choreographer.java:940)
                                                                                                    	at android.view.Choreographer.doFrame(Choreographer.java:873)
                                                                                                    	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1261)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:958)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:205)
                                                                                                    	at android.os.Looper.loop(Looper.java:294)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8128)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:578)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:946)

Screen_recording_20230505_153227.mp4

app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaAppState.kt

...nterests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/NewsUiState.kt

...erests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsItem.kt

app/src/main/java/com/google/samples/apps/nowinandroid/navigation/NiaNavHost.kt

alexvanyo · 2023-05-05T22:37:15Z

...rests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsRoute.kt

+            )
+        }
+
+        topicUiState?.let { state ->


If there is no topicUiState since there is no topicId, we could consider adding some sort of placeholder here in the case where we want to show 2 panes.

Sure, let's ask a designer to a mockup. Is it ok for you to do it in a separate PR, as an improvement?

Yep, that sounds good

I think a better solution here (but feel free to weigh in here @alexvanyo) would be to have a single pane/screen which shows all the topics using a 2 or 3 column layout, depending on width.

mmoczkowski · 2023-05-11T07:46:16Z

@alexvanyo Hey Alex, I have fixed the crash, PTAL 😄

...arks/src/main/java/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt

...rests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsRoute.kt

thagikura · 2023-05-12T05:46:52Z

...nterests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TopicScreen.kt

-            is TopicUiState.Success -> {
+            Error -> {
+                item {
+                    Text(text = "error")


I think this is still WIP for the error case?

It is! I didn't change here anything, it's still a WIP on the main branch as well. I would gladly address this, but prefer to do it as a separate PR. Is that ok?

Should be pretty simple to just add a string resource with an error message here

...s/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsViewModel.kt

thagikura

The change looks great!

Left some comments for nits and suggestions.

thagikura

Thanks! Looking good 👍

dturner · 2023-05-17T08:39:22Z

My first impressions of the layout on large screens are that we can make better use of the available space.

List-only screen

We could fit more topics on screen by switching to a 2 or 3 column layout here, which would reduce the amount of scrolling the user needs to do. We'd need to ensure that the checkbox or plus sign next to each topic is clearly associated with the topic on its left, not its right (maybe add a border or background?)

List-detail screen

Looking at the canonical layout for list-detail the list pane is actually narrower than the detail pane, rather than being equal to it. The topic titles aren't that long so we could reduce the width of the list pane quite a bit, allowing more space to the detail pane.

We could also increase the number of columns used to display news resources in the detail pane where screen width permits.

dturner · 2023-05-17T08:47:27Z

This PR also makes the topic chip click work, which was the 2nd part of the work started in #540.

dturner · 2023-05-17T10:52:17Z

...rests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsRoute.kt

+            )
+        }
+
+        topicUiState?.let { state ->


I think a better solution here (but feel free to weigh in here @alexvanyo) would be to have a single pane/screen which shows all the topics using a 2 or 3 column layout, depending on width.

...s/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsViewModel.kt

dturner · 2023-05-17T10:59:58Z

...nterests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TopicScreen.kt

-            is TopicUiState.Success -> {
+            Error -> {
+                item {
+                    Text(text = "error")


Should be pretty simple to just add a string resource with an error message here

dturner · 2023-05-17T16:46:00Z

We should also make this fold-aware, taking into account the hinge. Can test on Microsoft Duo.

mmoczkowski · 2023-05-26T12:17:40Z

We should also make this fold-aware, taking into account the hinge. Can test on Microsoft Duo.

@dturner Are you fin with implementing that in a separate PR? Don't want to make this one too large

app/src/main/java/com/google/samples/apps/nowinandroid/navigation/NiaNavHost.kt

app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt

app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaAppState.kt

...s/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsViewModel.kt

...nterests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TopicScreen.kt

manuelvicnt · 2023-05-29T13:03:26Z

...nterests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TopicScreen.kt

+        verticalArrangement = Arrangement.spacedBy(16.dp),
+        modifier = modifier
+            .selectableGroup()
+            .testTag("interests:topics"),


Is this 100% needed?

Do you mean the test tag?

...ava/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt

...erests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsItem.kt

alexvanyo · 2023-06-16T19:41:39Z

...erests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsItem.kt

-                .clickable { onClick() }
-                .padding(vertical = itemSeparation),
-        ) {
+    ListItem(


TIL about this component!

Change-Id: Id93161ac442b933db0eb35ce32f5b92bb4ef65d5

Change-Id: I1a985ded3cf5ca0eb01a6f8e167f1965f1e9fbdb

Change-Id: Ie4a782e2c26576098aff87ca164968886821cdcc

Change-Id: I341a6f7e16a270c3f093b8854b61199179c1d6aa

Change-Id: I5e1730118116530ef5104ffaeda0ec7d43fef736

Change-Id: I7b3ef8fb15990773b6aee9c6c2efc10fccb7be19

Change-Id: I253b06eeb0aa5dc3ecb784f290ae7246356ac4f7

Change-Id: I8601ed3bf475b6f97e9b586a8d1db32984e4c3e2

Change-Id: I9a5df4b5f071da3e01fadb3427906bd76e07de1e

Change-Id: Ifb05c761296a61f0eae78c04f1c0ec6ab416ca43

Change-Id: Ib25a9a3fce9a5e1a22a8be59ff5894298788354a

Change-Id: Id0f350b6f09c0ad148e6f60ad45d36db698dc397

alexvanyo · 2023-06-21T00:30:38Z

...rests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsRoute.kt

+            ) {
+                InterestsScreen(
+                    uiState = interestUiState,
+                    listState = listState,


One piece of behavior I noticed from sharing the list state: if you click on a item near the end of the grid, like Wear OS, the item isn't initially visible in the following view, because it is now off the screen.

dturner · 2023-06-21T16:52:45Z

Please could we add UI and navigation tests to verify this new behaviour. For example, that the list screen is displayed at full width when no topic detail is selected, and that the correct UI components/layouts are displayed at the various screen size classes.

mmoczkowski · 2023-07-05T13:09:55Z

Replaced with #807

alexvanyo self-requested a review April 28, 2023 17:40

mmoczkowski force-pushed the feature/interests-list-detail branch from 05c7a0a to 196685a Compare May 4, 2023 13:35

mmoczkowski marked this pull request as ready for review May 5, 2023 15:00

mmoczkowski force-pushed the feature/interests-list-detail branch from 1e83153 to 8386bbc Compare May 5, 2023 15:01

alexvanyo requested changes May 5, 2023

View reviewed changes

mmoczkowski force-pushed the feature/interests-list-detail branch from 8386bbc to 25638ee Compare May 9, 2023 11:24

mmoczkowski requested review from dturner and alexvanyo May 9, 2023 11:43

mmoczkowski force-pushed the feature/interests-list-detail branch from 2cbadce to 49b1c4b Compare May 10, 2023 12:35

mmoczkowski requested a review from thagikura May 11, 2023 11:30

thagikura reviewed May 12, 2023

View reviewed changes

...arks/src/main/java/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt Outdated Show resolved Hide resolved

thagikura reviewed May 12, 2023

View reviewed changes

...rests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsRoute.kt Show resolved Hide resolved

thagikura reviewed May 12, 2023

View reviewed changes

...s/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsViewModel.kt Outdated Show resolved Hide resolved

thagikura reviewed May 12, 2023

View reviewed changes

mmoczkowski force-pushed the feature/interests-list-detail branch from 8f0eb31 to 718d137 Compare May 15, 2023 11:35

mmoczkowski requested a review from thagikura May 15, 2023 12:57

thagikura approved these changes May 15, 2023

View reviewed changes

dturner requested changes May 17, 2023

View reviewed changes

mmoczkowski force-pushed the feature/interests-list-detail branch from 8912b42 to 6d77b0c Compare May 26, 2023 11:25

mmoczkowski requested a review from dturner May 26, 2023 12:18

manuelvicnt reviewed May 29, 2023

View reviewed changes

mmoczkowski force-pushed the feature/interests-list-detail branch 3 times, most recently from 96c80f2 to ccc59ed Compare June 5, 2023 10:57

mmoczkowski force-pushed the feature/interests-list-detail branch from 98ef853 to a11f2f4 Compare June 12, 2023 09:08

alexvanyo reviewed Jun 16, 2023

View reviewed changes

...erests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsItem.kt Outdated Show resolved Hide resolved

alexvanyo reviewed Jun 16, 2023

View reviewed changes

mmoczkowski added 13 commits June 20, 2023 13:15

Implement list/detail view for interests and topics

6c6538f

Fix interests screen test

6340c43

Change-Id: Id93161ac442b933db0eb35ce32f5b92bb4ef65d5

Spotless apply

9d16265

Change-Id: I1a985ded3cf5ca0eb01a6f8e167f1965f1e9fbdb

Improvements

cd0b092

Change-Id: Ie4a782e2c26576098aff87ca164968886821cdcc

Rename interestGraph to interestScreen

6af2a0a

Change-Id: I341a6f7e16a270c3f093b8854b61199179c1d6aa

Add border to selected topic item

f94c401

Change-Id: I5e1730118116530ef5104ffaeda0ec7d43fef736

Improve top bar

ea34249

Change-Id: I7b3ef8fb15990773b6aee9c6c2efc10fccb7be19

Fix NiaAppStateTest

2781cf2

Change-Id: I253b06eeb0aa5dc3ecb784f290ae7246356ac4f7

Fix InterestsScreenTest

021345c

Change-Id: I8601ed3bf475b6f97e9b586a8d1db32984e4c3e2

spotless

a6633fd

Change-Id: I9a5df4b5f071da3e01fadb3427906bd76e07de1e

Improve method name

b19e89d

Change-Id: Ifb05c761296a61f0eae78c04f1c0ec6ab416ca43

Refactor conditional modifier to use then function

8b29e7e

Change-Id: Ib25a9a3fce9a5e1a22a8be59ff5894298788354a

Spotless apply

380b949

Change-Id: Id0f350b6f09c0ad148e6f60ad45d36db698dc397

mmoczkowski force-pushed the feature/interests-list-detail branch from 11ba432 to 380b949 Compare June 20, 2023 11:32

alexvanyo reviewed Jun 21, 2023

View reviewed changes

mmoczkowski closed this Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement topics list/detail view for large screens #701

Implement topics list/detail view for large screens #701

mmoczkowski commented Apr 28, 2023 •

edited

Loading

alexvanyo left a comment

alexvanyo May 5, 2023

mmoczkowski May 11, 2023

alexvanyo May 12, 2023

dturner May 17, 2023

mmoczkowski commented May 11, 2023

thagikura May 12, 2023

mmoczkowski May 15, 2023

dturner May 17, 2023

thagikura left a comment

thagikura left a comment

dturner commented May 17, 2023 •

edited

Loading

dturner commented May 17, 2023

dturner May 17, 2023

dturner May 17, 2023

dturner commented May 17, 2023

mmoczkowski commented May 26, 2023 •

edited

Loading

manuelvicnt May 29, 2023

mmoczkowski May 31, 2023

alexvanyo Jun 16, 2023

alexvanyo Jun 21, 2023

dturner commented Jun 21, 2023

mmoczkowski commented Jul 5, 2023

Implement topics list/detail view for large screens #701

Implement topics list/detail view for large screens #701

Conversation

mmoczkowski commented Apr 28, 2023 • edited Loading

alexvanyo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmoczkowski commented May 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thagikura left a comment

Choose a reason for hiding this comment

thagikura left a comment

Choose a reason for hiding this comment

dturner commented May 17, 2023 • edited Loading

dturner commented May 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dturner commented May 17, 2023

mmoczkowski commented May 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dturner commented Jun 21, 2023

mmoczkowski commented Jul 5, 2023

mmoczkowski commented Apr 28, 2023 •

edited

Loading

dturner commented May 17, 2023 •

edited

Loading

mmoczkowski commented May 26, 2023 •

edited

Loading