Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new Activity.enableEdgeToEdge #817

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

alexvanyo
Copy link
Contributor

This switches over to the new Activity.enableEdgeToEdge call in androidx.compose.

This allows a bit of cleanup:

  • We no longer have as much themes.xml logic for the system bar color, as this is done programmatically
  • The system bar color is backported even better across API versions
  • We can remove accompanist/systemuicontroller as a dependency, since the only usage of it in this project is superceded by Activity.enableEdgeToEdge

@alexvanyo alexvanyo requested a review from yaraki June 22, 2023 23:05
@alexvanyo alexvanyo marked this pull request as ready for review July 11, 2023 22:49
@alexvanyo alexvanyo requested a review from dturner July 11, 2023 22:50
@lihenggui
Copy link
Contributor

There is a small UI change here
Before this change:
image
image

After the change:
image
image

Previously, the navigation bar was transparent, but after implementing this update, it will overlay a new background. It appears that this layer cannot be removed by setting the navigationBarStyle to SystemBarStyle.auto(android.graphics.Color.TRANSPARENT, android.graphics.Color.TRANSPARENT).

@yaraki
Copy link

yaraki commented Jul 24, 2023

Previously, the navigation bar was transparent, but after implementing this update, it will overlay a new background. It appears that this layer cannot be removed by setting the navigationBarStyle to SystemBarStyle.auto(android.graphics.Color.TRANSPARENT, android.graphics.Color.TRANSPARENT).

That's what API29+ does by default for 3-button nav. If you want transparent nav bar even for 3-button nav, you can do SystemBarStyle.dark(TRANSPARENT) or SystemBarStyle.light(TRANSPARENT, TRANSPARENT).

@lihenggui
Copy link
Contributor

Previously, the navigation bar was transparent, but after implementing this update, it will overlay a new background. It appears that this layer cannot be removed by setting the navigationBarStyle to SystemBarStyle.auto(android.graphics.Color.TRANSPARENT, android.graphics.Color.TRANSPARENT).

That's what API29+ does by default for 3-button nav. If you want transparent nav bar even for 3-button nav, you can do SystemBarStyle.dark(TRANSPARENT) or SystemBarStyle.light(TRANSPARENT, TRANSPARENT).

Thank you for your answer. : )

Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants